amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1759616249
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -304,6 +309,11 @@ private ManifestFile filterManifest(Schema tableSchema,
ManifestFile manifest) {
return manifest;
}
+ boolean hasDeletedFiles =
referencedManifestLocations.contains(manifest.path());
+ if (hasDeletedFiles) {
+ return filterManifestWithDeletedFiles(manifest, tableSchema);
+ }
Review Comment:
Updated my comment with a possibly more optimized way using positions:
https://github.com/apache/iceberg/pull/11131#issuecomment-2350698759
I'll explore this a bit more, but before that I'm going to look into how to
effectively benchmark this change so I'm measuring it the right way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
