amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1761479745
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -308,11 +316,15 @@ private ManifestFile filterManifest(Schema tableSchema,
ManifestFile manifest) {
PartitionSpec spec = reader.spec();
PartitionAndMetricsEvaluator evaluator =
new PartitionAndMetricsEvaluator(tableSchema, spec,
deleteExpression);
+ boolean hasDeletedFiles =
manifestDeletedPositions.containsKey(manifest.path());
+ if (hasDeletedFiles) {
+ return filterManifestWithDeletedFiles(evaluator, manifest, reader);
Review Comment:
The !canContainDeletedFiles(manifest) check already optimizes the case where
there is nothing to rewrite
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -308,11 +316,15 @@ private ManifestFile filterManifest(Schema tableSchema,
ManifestFile manifest) {
PartitionSpec spec = reader.spec();
PartitionAndMetricsEvaluator evaluator =
new PartitionAndMetricsEvaluator(tableSchema, spec,
deleteExpression);
+ boolean hasDeletedFiles =
manifestDeletedPositions.containsKey(manifest.path());
+ if (hasDeletedFiles) {
+ return filterManifestWithDeletedFiles(evaluator, manifest, reader);
Review Comment:
The !canContainDeletedFiles(manifest) check on 310 already optimizes the
case where there is nothing to rewrite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
