amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1761476386
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -421,7 +433,7 @@ private ManifestFile filterManifestWithDeletedFiles(
entry -> {
F file = entry.file();
boolean markedForDelete =
- deletePaths.contains(file.path())
+ fileIsDeleted(file, manifest)
Review Comment:
Also just noticed for the pos based comparison we may not be really
optimizing much since for the duplicate file detection case we do another
string comparison on line 457. So we really only remove one path string
comparison instead of all of them in the current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
