amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1761598959
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -153,6 +154,12 @@ void caseSensitive(boolean newCaseSensitive) {
void delete(F file) {
Preconditions.checkNotNull(file, "Cannot delete file: null");
invalidateFilteredCache();
+ if (file.manifestLocation() != null) {
+ deletedManifestPositions
+ .computeIfAbsent(file.manifestLocation(), key -> Sets.newHashSet())
+ .add(file.pos());
Review Comment:
We could optimize memory consumption by not populating `deletePaths` if the
manifest location is defined. Basically put line 162 to the rest of the method
behind an `else` block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
