amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1761439874
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -153,6 +154,12 @@ void caseSensitive(boolean newCaseSensitive) {
void delete(F file) {
Preconditions.checkNotNull(file, "Cannot delete file: null");
invalidateFilteredCache();
+ if (file.manifestLocation() != null) {
+ deletedManifestPositions
+ .computeIfAbsent(file.manifestLocation(), key -> Sets.newHashSet())
+ .add(file.pos());
Review Comment:
Note: The case where file.pos() is defined is the same as where
file.manifestLocation() is defined; as long as the file is read from a manifest
both of these will be set, so I don't think we need an additional null check
for `pos`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
