amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1761484377
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -308,11 +316,15 @@ private ManifestFile filterManifest(Schema tableSchema,
ManifestFile manifest) {
PartitionSpec spec = reader.spec();
PartitionAndMetricsEvaluator evaluator =
new PartitionAndMetricsEvaluator(tableSchema, spec,
deleteExpression);
+ boolean hasDeletedFiles =
manifestDeletedPositions.containsKey(manifest.path());
+ if (hasDeletedFiles) {
+ return filterManifestWithDeletedFiles(evaluator, manifest, reader);
Review Comment:
I think we can make the check in `canContainDeletedFiles` a bit more
efficient by checking if manifestDeletedPositions is not empty before doing any
of the more expensive checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
