amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1761333739
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -421,7 +433,7 @@ private ManifestFile filterManifestWithDeletedFiles(
entry -> {
F file = entry.file();
boolean markedForDelete =
- deletePaths.contains(file.path())
+ fileIsDeleted(file, manifest)
Review Comment:
Open to better names here, I was more so creating a helper method to group
the position based and the path based check, since there's a lot of conditions
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
