zackurey commented on PR #10373: URL: https://github.com/apache/iceberg/pull/10373#issuecomment-2134141718
👍 to the conservative approach being taken here to _not_ assume a failure is `Cleanable` unless explicitly categorized as such. I worry about the burden it puts on catalog implementations to categorize every error into either `CommitStateUnknown` or `CommitStateFailed`. We’ve encountered issues where edge cases manifest as generic RuntimeExceptions, which leads to inadvertent data file deletion. We run orphan file deletion frequently, so any data files that should have been reaped, but aren’t due to the change in behavior being introduced here, would have negligible COGs impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
