danielcweeks commented on PR #10373: URL: https://github.com/apache/iceberg/pull/10373#issuecomment-2130322881
@amogh-jahagirdar this might cover a few cases where a RuntimeException is thrown, but I think the underlying problem is more that a lot of the implementations throw CommitFailedException or RuntimeExceptions for a wide variety of cases that may or may not be cleanable. For example, I think JdbcTableOperations throws UncheckedSQLException for a lot of cases that are cleanable. Overall, I'm in favor of deferring to not cleaning up, but I think due to the current exception handling, there are lots of edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
