sumedhsakdeo commented on code in PR #10373:
URL: https://github.com/apache/iceberg/pull/10373#discussion_r1628766388
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -333,6 +333,8 @@ private void commitCreateTransaction() {
// the commit failed and no files were committed. clean up each update
if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
cleanAllUpdates();
+ } else if (ops.requireStrictCleanup()) {
Review Comment:
I believe this comment needs rewording:
https://github.com/apache/iceberg/blob/afc30818b734879e53a24f90f034685cf8fc56bc/core/src/main/java/org/apache/iceberg/TableOperations.java#L120
"would it now say if requiresStrictCleanup is true, we would NOT cleanup if
it was not a cleanableFailure", is there a easier way to represent this if-else
condition in that case."
+1 to being conservative we have been bitten multiple times with premature
cleanup by spark because the code raised unchecked exceptions such as
OutOfMemoryError. On that note, how are unchecked exceptions that derive from
Error class handled from cleanup perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
