amogh-jahagirdar commented on code in PR #10373:
URL: https://github.com/apache/iceberg/pull/10373#discussion_r1613629622
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -415,6 +415,8 @@ public void commit() {
} catch (RuntimeException e) {
if (!strictCleanup || e instanceof CleanableFailure) {
Exceptions.suppressAndThrow(e, this::cleanAll);
+ } else if (strictCleanup) {
+ throw new CommitStateUnknownException(e);
Review Comment:
Let me see about adding some tests, should be similar in principal to what
I did in
https://github.com/apache/iceberg/pull/8397/files#diff-37f64b622d5c3e0e890d94773e84ef49ceb3c1e9b0c03da313db9266b0e75afbR2051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
