stevenzwu commented on PR #10373: URL: https://github.com/apache/iceberg/pull/10373#issuecomment-2135677546
> Upstream callers of the transaction/snapshot producer APIs such as engines like Spark currently handle CommitStateUnknown exceptions to avoid cleaning up data files when it's unclear if the commit was successful or not. I like the introduction of the `CleanableFailure` marker interface for this purpose. Engines can potentially updated to reflect that intention. On the other hand, the challenge is that this is not defined in the spec. It may be less obvious to engine/catalog implementer. Some engines (like Spark) have learned to handle `CommitStateUnknownException`. Can we standardize on `CleanableFailure` for Java implementation? Can we add the behavior clarification to the spec? Seems that this PR is trying to standardize **uncleanable** commit errors to `CommiteStateUnknownException`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
