amogh-jahagirdar commented on code in PR #10373:
URL: https://github.com/apache/iceberg/pull/10373#discussion_r1613637717
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -436,6 +440,8 @@ private void commitSimpleTransaction() {
} catch (RuntimeException e) {
if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
cleanUpOnCommitFailure();
+ } else if (ops.requireStrictCleanup()) {
+ throw new CommitStateUnknownException(e);
Review Comment:
Yeah I probably should, it's failing the cyclomatic check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
