amogh-jahagirdar commented on code in PR #10373:
URL: https://github.com/apache/iceberg/pull/10373#discussion_r1645017182
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -333,6 +333,8 @@ private void commitCreateTransaction() {
// the commit failed and no files were committed. clean up each update
if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
cleanAllUpdates();
+ } else if (ops.requireStrictCleanup()) {
Review Comment:
No longer applicable. Just updated the approach; it's still conservative but
it puts the handling more on the Spark integration side to explicitly handle
CleanableFailure rather than the original approach which attempted to normalize
the unknown cases to CommitStateUnknownException; I think it's better because
that "normalization" may be quite hard and there maybe other cases.
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -333,6 +333,8 @@ private void commitCreateTransaction() {
// the commit failed and no files were committed. clean up each update
if (!ops.requireStrictCleanup() || e instanceof CleanableFailure) {
cleanAllUpdates();
+ } else if (ops.requireStrictCleanup()) {
Review Comment:
No longer applicable. Just updated the approach; it's still conservative but
it puts the handling more on the Spark integration side to explicitly handle
CleanableFailure rather than the original approach which attempted to normalize
the unknown cases to CommitStateUnknownException; I think it's better because
that "normalization" may be quite hard to achieve in practice and there maybe
other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
