amogh-jahagirdar commented on PR #10373: URL: https://github.com/apache/iceberg/pull/10373#issuecomment-2176908633
@stevenzwu I updated so that instead of normalizing non-cleanable failures to `CommitStateUnknownExcpetion` now engines, in this case Spark will explicitly handle `CleanableFailure`. It's a bit more implementation than the original approach since a few touchpoints in Spark integration needed to be updated but I think it makes more sense because in the original approach maybe there can be cases which still fail to actually get normalized to `CommitStateUnknown` exception (I think this is what @danielcweeks was getting at). Now it's explicit on the engine side we only cleanup if it's a cleanable failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
