Re: Moving plasma-mediacenter to extragear

2016-07-21 Thread Sinny Kumari
On Mon, Jul 18, 2016 at 2:29 PM, Bhushan Shah wrote: > Hello plasma team, > > I am not much happy to write this, but here it goes, > > Since last three Plasma release it always bugged me that there were no > usefull changes in plasma-mediacenter, mostly because after being > contracted by Bluesyst

Re: Merging new PMC design into master

2015-02-09 Thread Sinny Kumari
On Tue, Feb 10, 2015 at 11:10 AM, Bhushan Shah wrote: > I am going to merge this branch to master (which is already KF5 based) > today, this will allow users and VDG people to try out new user > interface without any hassle, so if you have any objections please > say. +1 Good to merge it to mas

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-08-26 Thread Sinny Kumari
handling fix in next patch like codec missing, inaccessible media played from media browser - Sinny Kumari On Aug. 24, 2014, 1:14 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-08-04 Thread Sinny Kumari
> On Aug. 1, 2014, 5:36 p.m., Sinny Kumari wrote: > > Couple of issues: > > 1. While I am playing songs from playlist, suppose there are three > > inaccessible media in between. Now, I press next then control will skip 3 > > inacessible media and will play 4th one. N

Re: Review Request 118866: Start playing after Play All is used

2014-08-03 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/#review63695 --- Ship it! Ship It! - Sinny Kumari On July 29, 2014, 12:35

Re: Review Request 118406: Notify the user if the location containing the media is inaccessible.

2014-08-01 Thread Sinny Kumari
e reason like renaming of media, deleting media or unmounting partition/device which is kind of deletion of media for my computer. - Sinny Kumari On Aug. 1, 2014, 4:03 p.m., R.Harish Navnit wrote: > > --- > This is an automat

Re: Review Request 111553: Fix for the Revision 2f4ab1e6 and Subtitle feature extension in PMC to .sub file format as well.

2014-07-30 Thread Sinny Kumari
it: > https://git.reviewboard.kde.org/r/111553/ > --- > > (Updated July 17, 2013, 5:25 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > >

Re: Review Request 111770: Implemented search feature in Local Browsing.

2014-07-30 Thread Sinny Kumari
> On Sept. 11, 2013, 7:31 a.m., Sinny Kumari wrote: > > One issue > > Suppose I searched for videos folder in search bar. Now, with search filter > > i can see videos folder in mediabrowser. Later when I click on video folder > > to broswe inside then it shows

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62748 --- Ship it! Ship It! - Sinny Kumari On July 20, 2014, 5:14

Re: Review Request 119250: Events and trips according to date ranges

2014-07-20 Thread Sinny Kumari
name shouldn't be created. Save button should be disabled until name some valid name is enterd 2. Creating a new event with an existing event name ends up editing same. Ideally, it should give error message saying event already exits. - Sinny Kumari On July 20, 2014, 3:08 p.m., Shantanu T

Re: Review Request 119250: Events and trips according to date ranges

2014-07-14 Thread Sinny Kumari
should be renamed to bar, but here a new event gets created with name bar and foo also exist. 3. When I edit an existing event with new date and click save, it still shows me images with previous saved date. To see images with modified date, I have to go back to folder and then it displays i

Re: cmake does not work

2014-07-10 Thread Sinny Kumari
On Thu, Jul 10, 2014 at 12:33 PM, Devanshu Jain wrote: > Sir, > I am new to open source commity and am trying to get involved with KDE > plasma media center. I am trying to build plasma media center on my pc. But > while running the command, I am getting the following message: > > ---

Re: Review Request 118866: Start playing after Play All is used

2014-06-21 Thread Sinny Kumari
consistency. Other than that Looks good to me. - Sinny Kumari On June 21, 2014, 5:43 p.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

2014-06-19 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60540 --- Ship it! Looks good to me. - Sinny Kumari On June 19

Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"

2014-06-19 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60539 --- Ship it! Looks good to me. - Sinny Kumari On June 19

Re: Ideas around Highlight

2014-06-15 Thread Sinny Kumari
On Sun, Jun 15, 2014 at 4:48 PM, Akshay Ratan wrote: > Hello, > > In my opinion, second highlight looks more crisp and sharp and hence > preferable. :) > > + 1 But I am not usability expert > > On Sun, Jun 15, 2014 at 3:54 PM, Shantanu Tushar Jha > wrote: > >> Hey folks, >> >> I recently added

Re: Ideas around Highlight

2014-06-15 Thread Sinny Kumari
CC'ing Thomas as well On Sun, Jun 15, 2014 at 3:54 PM, Shantanu Tushar Jha wrote: > Hey folks, > > I recently added a visual highlight in the All Music mode to help the user > follow the current focus[1]. > > I am wondering if the simple highlight looks better than > PlasmaComponents.Highlight,

Re: Review Request 118688: Avoid crash when artist is invalid

2014-06-12 Thread Sinny Kumari
org/r/118688/ > --- > > (Updated June 12, 2014, 6:51 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > --- > > Artist can be invalid, dont fetch art

Re: Review Request 117981: Filter out images with image width lesser than 500 pixel in Plasma media Center

2014-05-04 Thread Sinny Kumari
90a Diff: https://git.reviewboard.kde.org/r/117981/diff/ Testing --- Works as expected Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117981: Filter out images with image width lesser than 500 pixel in Plasma media Center

2014-05-03 Thread Sinny Kumari
d Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117931: Restrict sourceSize to screen size

2014-05-01 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117931/#review57065 --- Ship it! Ship It! - Sinny Kumari On May 1, 2014, 1:33 p.m

Re: Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-05-01 Thread Sinny Kumari
and all unit test passed Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-05-01 Thread Sinny Kumari
--- Application runs as expected and all unit test passed Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117923: Export everything by defult for test in plasmamediacentertest librray

2014-04-30 Thread Sinny Kumari
/singletonfactorytest.cpp PRE-CREATION libs/test/testhelpers.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117923/diff/ Testing --- Application runs as expected and all unit test passed Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma

Re: Review Request 117867: Do not cache media lists to a database

2014-04-30 Thread Sinny Kumari
in previous review. - Sinny Kumari On April 29, 2014, 1:13 p.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 117867: Do not cache media lists to a database

2014-04-30 Thread Sinny Kumari
iewboard.kde.org/r/117867/#comment39728> ${QT_QTSQL_LIBRARIES} and ${Boost_LIBRARIES shouldn't be needed now libs/mediacenter/medialibrary.h <https://git.reviewboard.kde.org/r/117867/#comment39731> shouldn't be required - Sinny Kumari On Apri

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-26 Thread Sinny Kumari
video on Kubuntu 14.04 and Fedora 19. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Sinny Kumari
f: https://git.reviewboard.kde.org/r/117691/diff/ Testing --- Able to play audio/video on Kubuntu 14.04 and Fedora 19. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Sinny Kumari
nu Tushar. I also think adding switch in CMake will be better rather than keeping as a patch. - Sinny --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56339 -

Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-22 Thread Sinny Kumari
newshell/CMakeLists.txt 9d9ea29 shells/newshell/mainwindow.h eb2b276 shells/newshell/mainwindow.cpp 9735a0a Diff: https://git.reviewboard.kde.org/r/117691/diff/ Testing --- Able to play audio/video on Kubuntu 14.04 and Fedora 19. Thanks, Sinn

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-04-14 Thread Sinny Kumari
r/116874/#comment38784> you can directly write enabled: runtimeData.url - Sinny Kumari On April 12, 2014, 3:23 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 117510: Remove extractAndSaveDurationInfo() and use the more generic setValueForRole()

2014-04-13 Thread Sinny Kumari
tps://git.reviewboard.kde.org/r/117510/#comment38688> Please remove whitespace before colon - Sinny Kumari On April 12, 2014, 10:55 a.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.

2014-03-19 Thread Sinny Kumari
d.kde.org/r/116874/ > --- > > (Updated March 18, 2014, 6 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 330990 and Bug > http://bugs.kde.org/show_bug.cgi?id=330990 > http://bugs.kde.org/show_bug.cgi?id=Bug > &

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Sinny Kumari
> On March 15, 2014, 2:38 p.m., Sinny Kumari wrote: > > shells/newshell/package/contents/ui/mediacenter.qml, line 366 > > <https://git.reviewboard.kde.org/r/116802/diff/1/?file=254061#file254061line366> > > > > Instead of pushing playlist and popping it bac

Re: Review Request 116802: Fix for "Bug 331919 - MediaPlayer is not in front when a media is played from 'Open With'"

2014-03-15 Thread Sinny Kumari
tps://git.reviewboard.kde.org/r/116802/#comment37283> Instead of pushing playlist and popping it back, its better to not push it. Just create the playlist using getPlaylist() and don't show it. - Sinny Kumari On March 14, 2014, 6:01 p.m., Ashish M

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Sinny Kumari
d March 5, 2014, 7:38 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > --- > > Playlist was not reachable from home screen as rep

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Sinny Kumari
dition) { // statement } else { // statement } - Sinny Kumari On March 5, 2014, 5:46 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Letting users customize the default background on PMC homescreen (Was: Re: Ideas Critical to PMC)

2014-02-26 Thread Sinny Kumari
On Thu, Feb 27, 2014 at 2:04 AM, Thomas Pfeiffer wrote: > On Tuesday 25 February 2014 10:48:47 Shantanu Tushar Jha wrote: > > Hi Harshit, > > > > First of all, just a note, whenever you have a new thing to discuss, it > is > > a bad idea to reply to an existing thread which is not directly related

Re: Review Request 116032: The MediaWindow was stopping on the last frame after the media finished playing. Through this patch, it returns back to the last window on the stack.

2014-02-25 Thread Sinny Kumari
x27;t have KDE developer account, I will commit changes on behalf of you :) - Sinny Kumari On Feb. 24, 2014, 10:29 p.m., Harshit Agarwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Re: Problems in building

2014-02-22 Thread Sinny Kumari
to do > On Sun, Feb 23, 2014 at 10:55 AM, Sinny Kumari wrote: > >> Hey, >> >> In order to know what is the reason of failing build, I need few >> information: >> >> 1. What distribution you are using ? >> 2. Which version of your distribution? >

Re: Problems in building

2014-02-22 Thread Sinny Kumari
Hey, In order to know what is the reason of failing build, I need few information: 1. What distribution you are using ? 2. Which version of your distribution? 3. Are you building master or some other branch? Thanks On Sat, Feb 22, 2014 at 11:51 PM, Devanshu Jain wrote: > Hi! > I was going thr

Re: Proposed fix for issue 330115

2014-01-28 Thread Sinny Kumari
On Mon, Jan 27, 2014 at 9:04 PM, R.Harish Navnit wrote: > On Mon, Jan 27, 2014 at 8:45 PM, Shantanu Tushar Jha wrote: > >> where COMMIT is the SHA of the commit just before your commits. >> > What does this mean ? > > In your example, you need to run "git diff >> 166b33610ceb4e06976570c66ad9fbc3

Re: Proposed fix for issue 330115

2014-01-28 Thread Sinny Kumari
On Tue, Jan 28, 2014 at 4:21 PM, R.Harish Navnit wrote: > On Mon, Jan 27, 2014 at 10:02 PM, Shantanu Tushar Jha wrote: > >> The diff you get should look like this http://pastebin.kde.org/pcydxtqcg. >> > > >> The easier thing imo would be to make a fresh clone, re-apply your changes >> > Oh my god

Re: Proposed fix for issue 330115

2014-01-24 Thread Sinny Kumari
> This link is not what you wanted to paste ;) > Also, send diff of code by using "git diff". It will be easier to llok > into issue :) > s/ llok/look typo -- http://www.sinny.in ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Proposed fix for issue 330115

2014-01-24 Thread Sinny Kumari
On Fri, Jan 24, 2014 at 5:44 PM, R.Harish Navnit wrote: > Hi , > > I tried running the application after removing the "else continue > statement" , it doesn't seem to work yet . This is the output log : > http://pastebin.kde.org/ . > This link is not what you wanted to paste ;) Also, send diff of

Re: Proposed fix for issue 330115

2014-01-23 Thread Sinny Kumari
Hi Harish, You have done great job!. Few things I want to say: 1. Try to post queries on plasma-devel Mailing List so that you don't have to wait for reply from one person, any one can reply to you. 2. You don't need to add plasma-mediacenter project on github. Its source code with all git summar

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-21 Thread Sinny Kumari
- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115162/ > --- > > (Updated Jan. 21, 2014, 6:44 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. &g

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2014-01-21 Thread Sinny Kumari
, Someone else should also review code wise because I don't have much idea about creating single application instance. - Sinny Kumari On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote: > > --- > This is an automatically genera

Re: Error(Cmake) while building PMC

2014-01-14 Thread Sinny Kumari
On Tue, Jan 14, 2014 at 7:57 PM, R.Harish Navnit wrote: > omg! You got some stuff messed up. It is weird why you have Qt5 >> development headers installed, do you remember installing it? >> > > Yes , it sure looks messed up ! I remember installing a lot of packages > while building digikam(which a

Re: Error(Cmake) while building PMC

2014-01-14 Thread Sinny Kumari
On Tue, Jan 14, 2014 at 4:06 PM, R.Harish Navnit wrote: > Okay now I've been trying the build on my Ubuntu 13.04 with KDE plasma > Workspace(It now shows Kubuntu on boot) . > This is the error log that I get : http://pastebin.kde.org/pee7kzjwx > By looking into error message, issue is most proba

Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments

2014-01-07 Thread Sinny Kumari
x27;t move to Misc playlist when opened through command line or dolphin. - Sinny Kumari On Jan. 7, 2014, 8:01 a.m., Sujith Haridasan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 114741: Add time duration to media item for youtube videos.

2013-12-31 Thread Sinny Kumari
:) - Sinny Kumari On Dec. 31, 2013, 6:46 a.m., Sudhendu Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 114634: Make playlist switching code simpler

2013-12-24 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114634/#review46129 --- Ship it! Looks good to me. - Sinny Kumari On Dec. 23

Re: Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-16 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114482/#review45798 --- Ship it! Ship It! - Sinny Kumari On Dec. 16, 2013, 11:49

Re: Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-16 Thread Sinny Kumari
your local branch first and then upload diff. - Sinny Kumari On Dec. 16, 2013, 5:58 a.m., Sujith Haridasan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 114482: Plasma-mediacenter remember last played playlist

2013-12-15 Thread Sinny Kumari
uld go into C++ i.e destructor of playlist - Sinny Kumari On Dec. 15, 2013, 5:35 p.m., Sujith Haridasan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

2013-11-27 Thread Sinny Kumari
if you have KDE developer account, if not then I will do that. - Sinny Kumari On Nov. 27, 2013, 4:02 p.m., Egor Matirov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

2013-11-27 Thread Sinny Kumari
ctory mediaelements/imageviewer/PictureStrip.qml <http://git.reviewboard.kde.org/r/114152/#comment31827> index of Listview starts from 0 to (total count -1), so while assigning value of count make it imageList.count - 1 - Sinny Kumari On Nov. 27, 2013, 3:01 p.m., Egor Ma

Re: Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging fails searching for translations

2013-11-26 Thread Sinny Kumari
translation works fine there. It would be great to know from others as well if these changes don't create any problem in other distro. - Sinny Kumari On Nov. 23, 2013, 5:23 p.m., Siddharth Sharma wrote: > > --- > This is an

Re: [PMC] Review of major refactoring around All Music mode

2013-09-25 Thread Sinny Kumari
Hi Shantanu, Thank you so much for putting so much effort on re-factoring fabian's branch. I checked almost all major/minor features which i remember and all of them works absolutely fine. There are some UI issues which can be fixed later, but functionality wise most of the stuff works fine. If n

Getting started wiki for Plasma Media Center (PMC)

2013-09-17 Thread Sinny Kumari
Hi, I have written a wiki page on getting started with PMC, keeping in mind a new developer who wants to know about PMC and start contributing to it. This wiki should guide that person in such a way that he/she can easily get all basic information at one place. Wiki page link is community.kde.org/

Re: please help

2013-09-12 Thread Sinny Kumari
Hi Kaushik, I am glad to know that you want to contribute into Plasma Media Center project. Since you know c++, it won't be much difficult for you in getting started with this project. Please follow whatever mentioned by Sebastian and Shantanu. To know more about Plasma Media Cenetr, you can tak

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-09-11 Thread Sinny Kumari
> On Sept. 11, 2013, 7:31 a.m., Sinny Kumari wrote: > > One issue > > Suppose I searched for videos folder in search bar. Now, with search filter > > i can see videos folder in mediabrowser. Later when I click on video folder > > to broswe inside then it shows

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-09-11 Thread Sinny Kumari
where user typed it - Sinny Kumari On Sept. 10, 2013, 7:31 p.m., Akshay Ratan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-09-11 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111863/#review39796 --- Ship it! works fine for me - Sinny Kumari On Sept. 11

Re: Review Request 112105: [1.1] PMC fix for KDE 4.11 - prevent deletion of popped pages from PageStack

2013-08-15 Thread Sinny Kumari
fine on KDE 4.10 too. - Sinny Kumari On Aug. 15, 2013, 5:49 p.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing

2013-08-06 Thread Sinny Kumari
y else keep previous logic (i.e files) for getting thumbnail of pictures. - Sinny Kumari On Aug. 5, 2013, 4:33 p.m., Akshay Ratan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 111801: Minor fix in Local Browsing Search

2013-07-30 Thread Sinny Kumari
t27172> else statement should be written in same line to closing curly brace of if Syntax: if (condition) { // statement } else { // statement } Works perfectly! Ship it after fixing these small issues - Sinny Kumari On July 30, 2013, 6:12 p.m.

Re: Review Request 111770: Implemented search feature in Local Browsing.

2013-07-29 Thread Sinny Kumari
("") - Places have search option too but search doesn't work there Most important thing, please push changes into a separate branch not in master for now. - Sinny Kumari On July 28, 2013, 8:08 p.m., Akshay Ratan wrote: > >

Re: Plasma Media Center build failure

2013-07-07 Thread Sinny Kumari
Hi, http://commits.kde.org/plasma-mediacenter/1176e15af7e07f47eeb8991b42ba72fa4b383d52should fix build failure now. Please let me know if it still fails Thanks On Sun, Jul 7, 2013 at 4:24 PM, Ben Cooksley wrote: > Hi all, > > It appears that since commit 58e32d0979920b2b6b03f9b8f91a68dc4f88e6

Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center

2013-07-03 Thread Sinny Kumari
/localfilesabstractmodel.cpp <http://git.reviewboard.kde.org/r/111337/#comment26092> remove extra whitespaces - Sinny Kumari On July 3, 2013, 10:03 a.m., Akshay Ratan wrote: > > --- > This is an automatically generated e

Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter

2013-06-27 Thread Sinny Kumari
ot being used in multiple functions. So, make it local to expand() browsingbackends/localfiles/localfilesabstractbackend.cpp <http://git.reviewboard.kde.org/r/111263/#comment25778> not required here - Sinny Kumari On June 27, 2013, 5 p.

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-24 Thread Sinny Kumari
org/r/87/ > --- > > (Updated June 23, 2013, 2:26 p.m.) > > > Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and > Sujith Haridasan. > > > Description > --- > > Using a PageStack for navigation in PMC has lots of benefits, the most

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sinny Kumari
video is visible. It looks little awkward. Expected behaviour: Only video player should be visible - Sinny Kumari On June 23, 2013, 2:26 p.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 111187: Implement UI navigation using PageStack

2013-06-23 Thread Sinny Kumari
iewer.qml <http://git.reviewboard.kde.org/r/87/#comment25563> Instead of adding MouseArea to Image element, it should be given to outer element FocusScope. Useful in case of small image. - Sinny Kumari On June 23, 2013, 9:06 a.m.,

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-20 Thread Sinny Kumari
will suggest ship diff r2 because it handle all major cases. Remaining cases we can handle when we re-write keyboard navigation stuff. - Sinny Kumari On June 20, 2013, 12:19 p.m., Shantanu Tushar wrote: > > --- > This is an auto

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-19 Thread Sinny Kumari
Whatever I mentioned in my last comment still doesn't work. - Sinny Kumari On June 19, 2013, 6 p.m., Shantanu Tushar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Re: Review Request 111047: Handle edge cases when going back/escape

2013-06-16 Thread Sinny Kumari
reproduce: - Launch PMC and open any backend other than All Music - Now, go to All Music and try pressing esc. It doesn't work - Sinny Kumari On June 16, 2013, 2:33 p.m., Shantanu Tushar wrote: > > --- > This is an automatically ge

Re: Plasma Media center v1.1.0 is in feature freeze

2013-06-16 Thread Sinny Kumari
On Sun, Jun 16, 2013 at 3:00 AM, Aaron J. Seigo wrote: > On Sunday, June 16, 2013 01:08:47 Sinny Kumari wrote: > > Hi, > > > > Now, Plasma Media Center v1.1.0 is in feature freeze. No new feature will > > be added to master. Only bug fixes will be done. > > co

Plasma Media center v1.1.0 is in feature freeze

2013-06-15 Thread Sinny Kumari
Hi, Now, Plasma Media Center v1.1.0 is in feature freeze. No new feature will be added to master. Only bug fixes will be done. New features will go into separate branches. Thanks -- http://www.sinny.in ___ Plasma-devel mailing list Plasma-devel@kde.o

Re: Review Request 111035: Merging sinny-youtube branch to master

2013-06-15 Thread Sinny Kumari
.png Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111035: Merging sinny-youtube branch to master

2013-06-14 Thread Sinny Kumari
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_1.png http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play_1.png Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma

Re: Review Request 111034: Merging sinny-youtube branch to master

2013-06-14 Thread Sinny Kumari
://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video.png http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play.png http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_1.png Thanks, Sinny Kumari

Review Request 111034: Merging sinny-youtube branch to master

2013-06-14 Thread Sinny Kumari
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video.png http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play.png Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma

Re: Review Request 111006: Escape Key fix in the media player

2013-06-14 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111006/#review34368 --- Ship it! Looks good to me. Ship it! - Sinny Kumari On June

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Sinny Kumari
ttp://git.reviewboard.kde.org/r/110776/#comment24815> Instead of checking if(mediaImageViewer.visible || mediaPlayer.hasVideo), check for if((mediaImageViewer.source != "") || (mediaPlayer.url != "") It will handle Music mode too - Sinny Kumari On June

Re: Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

2013-06-02 Thread Sinny Kumari
ny of empty space. I tried this and it was working fine. Rest is fine :) - Sinny Kumari On June 2, 2013, 8:01 a.m., Akshay Ratan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: Review Request 110620: Message extraction in Plasma Media Center

2013-05-24 Thread Sinny Kumari
://git.reviewboard.kde.org/r/110620/diff/ Testing --- Verified Message extraction as suggested. Works fine for me. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110620: Message extraction in Plasma Media Center

2013-05-24 Thread Sinny Kumari
: http://git.reviewboard.kde.org/r/110620/diff/ Testing (updated) --- Verified Message extraction as suggested. Works fine for me. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 110620: Message extraction in Plasma Media Center

2013-05-23 Thread Sinny Kumari
--- Hopefully works fine. Don't know how to test this. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 110620: Message extraction in Plasma Media Center

2013-05-23 Thread Sinny Kumari
x27;t know how to test this. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110512: Feature Review Request: Tab Control in Picasa Backend Login in Plasma Media Center.

2013-05-18 Thread Sinny Kumari
org/r/110512/ > --- > > (Updated May 18, 2013, 6:25 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Description > --- > > Tab Control in Picasa Backend Login in Plasma Media Center. > > Pressing Tab on either userID space, password s

Re: Patch Review

2013-05-15 Thread Sinny Kumari
Cool! patch works fine :) On Thu, May 16, 2013 at 2:17 AM, Marco Martin wrote: > On Wednesday 15 May 2013, Akshay Ratan wrote: > > Hi, > > With regard to the bug :: > https://bugs.kde.org/show_bug.cgi?id=319626 , > > I have submitted a patch for review. Its a very minor change as per the >

Re: FW: GSOC-2013 Proj- PMC rel. queries

2013-04-24 Thread Sinny Kumari
On Wed, Apr 24, 2013 at 10:41 PM, Shantanu Tushar Jha wrote: > Hi Saurabh, > > Nice to see your interest in Plasma Media Center, find my comments inline. > Also, you don't have to use sir/madam etc in your emails, just use people's > names to address them :) > > +1 No sir / madam On Wed, Apr 24,

Re: proposal ideas

2013-04-22 Thread Sinny Kumari
Hi Sunanda ! As shantanu suggested , first install PMC and then use it. Further, see what improvements you can think of in existing PMC in terms of UI or existing features improvement. Some of them are already listed on KDE's idea page http://community.kde.org/GSoC/2013/Ideas#Project:_Improvemen

Re: GSOC-2013 Proj- PMC rel. queries

2013-04-19 Thread Sinny Kumari
Doing CC to plasma-devel Thanks Saurabh for you effort. Nice start! On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote: > Dear mam, > > Thanks for replying me back and presenting your views. Yes, you were right > and I did deviate from the main point as I used the software and liked the > id

Re: GSOC Project Proposal Draft :: Improvement and Enhancements for Plasma Media Center

2013-04-18 Thread Sinny Kumari
orking you will get familiar with PMC codebase and meanwhile you may get some more PMC improvement ideas. > Thanks in advance ! > > Cheers, > Akshay Ratan > > On Wed, Apr 17, 2013 at 11:58 PM, Sinny Kumari wrote: > >> >> Overall, draft proposal looks good to me :

Re: GSoC Proposal

2013-04-18 Thread Sinny Kumari
Hi Ajay, Good to know that you want to work on "Improvements and enhancements for Plasma Media Center". I think you need to take a look at how proposal look like, some of them you can find here https://docs.google.com/document/pub?id=1Iqk8MTix2CN1pAgqhZqhefKTwiA7P73zQH9N46lvyB0. You need to know

Re: GSOC Project Proposal Draft :: Improvement and Enhancements for Plasma Media Center

2013-04-17 Thread Sinny Kumari
ink: > https://dl.dropboxusercontent.com/u/107169565/GSOC_Proposal_Draft.doc . > > Regards, > Akshay Ratan > (akshay_r #plasma #kde-devel) > > > > On Fri, Apr 12, 2013 at 11:28 PM, Sinny Kumari wrote: > >> Doing CC to plasma-devel >> >> You need to send email to pla

Re: GSOC Project Proposal Draft :: Improvement and Enhancements for Plasma Media Center

2013-04-14 Thread Sinny Kumari
Thanks Thomas! It will be really awesome :) On Sun, Apr 14, 2013 at 11:42 PM, Thomas Pfeiffer wrote: > On Sunday 14 April 2013 23:33:25 Sinny Kumari wrote: > > If you'd like, I can co-mentor this project from the usability perspective, > especially regarding use in Plasma A

  1   2   >