-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111770/#review36734
-----------------------------------------------------------
I see couple issues here:
- Pressing esc key always gives focus to search bar and it types one whitespace
into it which is not correct
- Whenever user search for something in search bar, later when user press
esc/back or browse into any directory, focus should be given to mediabrowser
elements instead of search bar and search field should be reset to blank ("")
- Places have search option too but search doesn't work there
Most important thing, please push changes into a separate branch not in master
for now.
- Sinny Kumari
On July 28, 2013, 8:08 p.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111770/
> -----------------------------------------------------------
>
> (Updated July 28, 2013, 8:08 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
> Haridasan.
>
>
> Description
> -------
>
> Plasma Media Center now supports searching in local files and media. Used
> Regular expression to match the name.
>
>
> Diffs
> -----
>
> browsingbackends/localfiles/localfilesabstractbackend.h 84758e4
> browsingbackends/localfiles/localfilesabstractbackend.cpp 1144e49
> browsingbackends/localfiles/localfilesabstractmodel.h 43f50b7
> browsingbackends/localfiles/localfilesabstractmodel.cpp ebfc602
>
> Diff: http://git.reviewboard.kde.org/r/111770/diff/
>
>
> Testing
> -------
>
> Works as intended.
>
>
> Thanks,
>
> Akshay Ratan
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
