----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110776/#review33583 -----------------------------------------------------------
shells/newshell/package/contents/ui/mediacenter.qml <http://git.reviewboard.kde.org/r/110776/#comment24815> Instead of checking if(mediaImageViewer.visible || mediaPlayer.hasVideo), check for if((mediaImageViewer.source != "") || (mediaPlayer.url != "") It will handle Music mode too - Sinny Kumari On June 2, 2013, 1:04 p.m., Akshay Ratan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110776/ > ----------------------------------------------------------- > > (Updated June 2, 2013, 1:04 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Description > ------- > > Clicking on the Empty top and bottom spaces of the Plasma Media Center's > Homescreen takes the user back to the media being played--Video or Slideshow. > > When user is viewing the pictures and comes on the main screen of the PMC, > now when he/she clicks the empty welcome screen , directly slideshow appears > as intended. > > Same is the case with videos. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=317451. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=317451 > > > Diffs > ----- > > mediaelements/mediabrowser/MediaBrowser.qml d978285 > mediaelements/mediawelcome/MediaWelcome.qml c524582 > shells/newshell/package/contents/ui/mediacenter.qml b4a659a > > Diff: http://git.reviewboard.kde.org/r/110776/diff/ > > > Testing > ------- > > Yes, works as intended. > > Please check for the Escape key navigation to see if it does not break the > keyboard navigation flow somewhere. > > > Thanks, > > Akshay Ratan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
