----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62321 -----------------------------------------------------------
+1 for this new backend. Other than already mentioned feedback, few things which need to be fixed are: 1. When I click on button "Add event or trip", later I press escape/back and return back without actually cretaing any event. Now, if I again click on button "Add event or trip", it doesn't lead me to new page which allows user to create a new event. Even, edit button also doesn't work. 2. Suppose, I have an event name "foo" and I browse into it. Now, I press "edit" button in order to edit event. Now, I changed my event "foo" to "bar". I would expect that my existing event foo should be renamed to bar, but here a new event gets created with name bar and foo also exist. 3. When I edit an existing event with new date and click save, it still shows me images with previous saved date. To see images with modified date, I have to go back to folder and then it displays images with modified time. - Sinny Kumari On July 12, 2014, 6:13 p.m., Shantanu Tushar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119250/ > ----------------------------------------------------------- > > (Updated July 12, 2014, 6:13 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > I got this idea on a recent trip that usually a family would have a device > where they store their trips/events photos on. Easier than tagging > everything, what if you could just say "Hey, I went to Kashmir during 5 April > to 14 April 2014" and voila! > > This backend implements this idea in a (hopefully) easy-to-use way. I'll love > to hear some feedback around this :) > > > Diffs > ----- > > browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp > PRE-CREATION > browsingbackends/metadatabackends/CMakeLists.txt ae56603 > browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp > PRE-CREATION > libs/mediacenter/backendsmodel.cpp 2823fb6 > libs/mediacenter/filtermediamodel.h b8272f6 > browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventsbackend.h > PRE-CREATION > > browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml > PRE-CREATION > > browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp > PRE-CREATION > browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119250/diff/ > > > Testing > ------- > > Seems to work as expected, I will be attaching screenshots. > > > File Attachments > ---------------- > > Showing events > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png > Showing photos from an event > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png > Editing dates of an existing event > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png > > > Thanks, > > Shantanu Tushar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
