----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/#review47913 -----------------------------------------------------------
Good work sujith! It works fine as expected. Preferably, Someone else should also review code wise because I don't have much idea about creating single application instance. - Sinny Kumari On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115162/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 6:44 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > Launching single instance of plasma-mediacenter. Using KUniqueApplication > only single instance of plasma-mediacenter is launched. > > > Diffs > ----- > > shells/newshell/CMakeLists.txt 60949df > shells/newshell/application.h PRE-CREATION > shells/newshell/application.cpp PRE-CREATION > shells/newshell/main.cpp 9fd5df3 > shells/newshell/plasma-mediacenter.desktop c3c5781 > > Diff: https://git.reviewboard.kde.org/r/115162/diff/ > > > Testing > ------- > > Tests done using konsole: > a) Open a tab and launch pmc. > b) Open another tab and try to launch another instance of pmc. > c) After executing (b) pmc wont launch because already another instance of > pmc from (a) is already running. > > Tests done using Dolphin: > a) Go to the music folder and right click on the file to be played. Click > open with and launch pmc. > b) Try to open another file using same step as (a) > c) After executing (b) wait for few seconds and you can see that only single > instance of (a) will be running. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
