----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114482/#review45726 -----------------------------------------------------------
Great work sujith! Settings gets restored in ideal case but this approach is introducing bus in multiple playlists. e.g Suppose you have created 3 playlists and right now you have selected 2nd playlist. Now you removed 2nd Playlist and closed Plasma Media Center. Next time when you open Plasma Media Center, you have wrong playlist name as stored as current playlist name which leads to weird behaviour in Playlists. I would suggest, save the settings of current playlist when destructor of playlist get called not in QML. mediaelements/playlist/MultiplePlaylists.qml <http://git.reviewboard.kde.org/r/114482/#comment32661> This logic should go into C++ i.e destructor of playlist - Sinny Kumari On Dec. 15, 2013, 5:35 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114482/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2013, 5:35 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > With this change Plasma-mediacenter now remembers the last playlist used by > user. Hence if there are playlists a, b, c and user selects playlist b and > listens songs in it and closes Plasma-mediacenter. When Plasma-mediacenter > relaunched, user can see the playlist b opened in the view. > > > Diffs > ----- > > mediaelements/playlist/MultiplePlaylists.qml 42877f0 > > Diff: http://git.reviewboard.kde.org/r/114482/diff/ > > > Testing > ------- > > Tested with 3 playlists and it worked properly. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
