----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111337/#review35528 -----------------------------------------------------------
Ship it! Good work Akshay :) browsingbackends/localfiles/localfilesabstractmodel.cpp <http://git.reviewboard.kde.org/r/111337/#comment26092> remove extra whitespaces - Sinny Kumari On July 3, 2013, 10:03 a.m., Akshay Ratan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111337/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 10:03 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, Sujith Haridasan, > and Thomas Pfeiffer. > > > Description > ------- > > This patch aims to enhance the file-browsing capability and navigation in the > plasma-mediacenter. Implemented a stack to store the browsing URLs and thus > ensure that the user can select another drive by coming to the PLACE MODEL > screen on pressing escape/back required number of times. Further, earlier on > clicking BROWSE Pics/Music/Videos , PMC took us to the last browsing folder > but now we get back to the PLACE MODEL screen on clicking it which is more > convenient for the user as he/she has all the options again to browse > whatever drive they want to. > > > Diffs > ----- > > browsingbackends/localfiles/localfilesabstractbackend.cpp 33ea4ef > browsingbackends/localfiles/localfilesabstractmodel.cpp a02e65d > > Diff: http://git.reviewboard.kde.org/r/111337/diff/ > > > Testing > ------- > > Yes, works as intended. > > However there seems to be one small glitch:: > Steps to reproduce--- > 1) Select a drive from PLACES MODEL screen eg FOO > 2) Select a folder eg BAR > 3) Select a folder inside again eg BAR2 . Now press escape/back, you will > successfully go one level back to BAR. > 4) Now try pressing ESCAPE/BACK, ideally PLACES MODEL Screen should be shown > , but you will notice, you have to press 2 escape/back keys to go there. > > Rest all works as intended and NO application crashes were experienced. > > > Thanks, > > Akshay Ratan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
