----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111263/#review35180 -----------------------------------------------------------
Ship it! Good work! After fixing mentioned minor issues, ship it! Also try to give whitespace before and after '=' operator for clarity. We will discuss issue related to showing places on email/IRC. browsingbackends/localfiles/localfilesabstractbackend.h <http://git.reviewboard.kde.org/r/111263/#comment25776> m_index variable is not being used in multiple functions. So, make it local to expand() browsingbackends/localfiles/localfilesabstractbackend.cpp <http://git.reviewboard.kde.org/r/111263/#comment25778> not required here - Sinny Kumari On June 27, 2013, 5 p.m., Akshay Ratan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111263/ > ----------------------------------------------------------- > > (Updated June 27, 2013, 5 p.m.) > > > Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, > and Sujith Haridasan. > > > Description > ------- > > The File explorer/browser in the plasma-mediacenter has been revamped. The > side-panel has been removed. Now the drives and other system directories > appears on clicking "Browse Pics/Music/Videos" instead of "home" folder > contents appeaaring earlier after selecting this particular option. > > > Diffs > ----- > > browsingbackends/localfiles/localfilesabstractmodel.h c4c8be3 > browsingbackends/localfiles/localfilesabstractbackend.cpp 5768fb3 > browsingbackends/localfiles/localfilesabstractmodel.cpp 6c66b43 > browsingbackends/localfiles/localmusic/CMakeLists.txt 4b804ae > browsingbackends/localfiles/localpictures/CMakeLists.txt c7ba5fa > browsingbackends/localfiles/localplacesmodel.h PRE-CREATION > browsingbackends/localfiles/localplacesmodel.cpp PRE-CREATION > browsingbackends/localfiles/localvideos/CMakeLists.txt 15677d7 > browsingbackends/localfiles/localfilesabstractbackend.h b7cc909 > > Diff: http://git.reviewboard.kde.org/r/111263/diff/ > > > Testing > ------- > > Major things working fine , but there might be certain issues regarding the > correct folder contents shown inside any folder in any particular directory. > > Further malformed url might appear on clicking certain drives. However this > can be fixed later :) > > > Thanks, > > Akshay Ratan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
