D28740: [Notifications] Don't show do not disturb end date beyond 100 days

pino added a comment. Wouldn't be better instead to not display a date in case the "until turned off" option is chosen? I personally found it confusing the first time I chose this option, and yet a date was shown. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.

D27980: make opengl module support multiple dri devices

pino added inline comments. INLINE COMMENTS > sitter wrote in opengl.cpp:210 > Is that also true for paths that are only ascii? Specifically path is a /dev > node. sure, i get this specific path is ascii the general recommendation is to use QFile::encodeName for QString -> C paths conversions

D27980: make opengl module support multiple dri devices

pino added inline comments. INLINE COMMENTS > opengl.cpp:169 > + > +bool isValid() > +{ const > opengl.cpp:210 > struct stat fileInfo; > -if (::stat("/dev/dri/card0", &fileInfo) != 0) > -return false; > -if ((fileInfo.st_mode & S_IFCHR) != S_IFCHR) > -return

D27574: Remove bold formatting of device name

pino added inline comments. INLINE COMMENTS > devicedetails.cpp:117 > { > -m_ui->remoteName->setText(QStringLiteral("%1").arg(name)); > +m_ui->remoteName->setText(QStringLiteral("%1").arg(name)); > } then you can simply remove the string+arg... REPOSITORY R97 Bluedevil REVISION DET

D27555: Add a category for kde-only and gnome-only apps

pino added a comment. Whatever is the outcome of this, please do not use contractions, as they are obscure and they may not work in non-English languages. Also, what about other DEs such as XFCE, LxQt, Cinnamon, Mate, etc? REPOSITORY R134 Discover Software Store REVISION DETAIL https:/

D27420: [Applet]Improvements for unavailable port.

pino added inline comments. INLINE COMMENTS > ListItemBase.qml:357 > +if (port.name == "analog-output-speaker" || > port.name == "analog-input-microphone-internal") { > +menuItem.text += i18nc("Port is > unavailable", " (unavailable)")

D27137: Handle spawning kinfocenter with a full path

pino added a comment. In D27137#605459 , @davidedmundson wrote: > If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in the first place Hello symlink my old friend... REPOSITORY R124 System Settings BRANCH master

D27137: Handle spawning kinfocenter with a full path

pino added inline comments. INLINE COMMENTS > main.cpp:42 > +BaseMode::ApplicationMode mode = BaseMode::SystemSettings; > +if (executableName.endsWith(QLatin1String("kinfocenter"))) { > +binaryName = QStringLiteral("kinfocenter"); This will consider also `/usr/bin/my-kinfocenter`

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. @aspotashev: please read the discussion in this review request... REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23783 To: romangg, #plasma, victorr, yurchor Cc: aspotashev, ltoscano, zzag, pino, plasma-devel, LeGast00n, The-Feren-OS-Dev, jral

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. BTW: if by 2200 UTC none of the two solutions mentioned above (continuation lines, or single long lines) is implemented, I will revert the majority of a798e78d477e (leaving only the .pot renami

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527719 , @romangg wrote: > In D23783#527582 , @pino wrote: > > > It's a normal QML function ... > > > If it's just a QML function why is it a problem to `+` some

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527600 , @romangg wrote: > diff --git a/kcm/package/contents/ui/main.qml b/kcm/package/contents/ui/main.qml > index 2e61aa5..191daf3 100644 > --- a/kcm/package/contents/ui/main.qml > +++ b/kcm/package

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527581 , @romangg wrote: > In D23783#527579 , @pino wrote: > > > Which macro? > > > `i18n(...)` or "function"? It's a normal QML function ... REPOSITORY

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. In D23783#527575 , @romangg wrote: > In D23783#527562 , @pino wrote: > > > Please do not split the messages just for sake of column width. > > > If there is a better soluti

D23783: [kcm] Fix i18n output file name and split texts

pino added a comment. Please do not split the messages just for sake of column width. What about just removing the `+` to concatenate the strings, and just use normal continuation, i.e.: text: i18n("Are you sure you want to disable all outputs? " "This might render t

D23250: Try to fix i18n() timing error in version strings

pino added a comment. This looks like a workaround to me: if `installedVersion` is not available (is it known when, actually?), why keep using it anyway, with or without i18n? Also, -1 to string puzzles and to UI strings not translatable. REPOSITORY R134 Discover Software Store REVISION

D22616: Remove phonon KCM

pino added a comment. In D22616#499453 , @nicolasfella wrote: > > @sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them > > this ... doesn't say anything. Before

D22616: Remove phonon KCM

pino added a comment. Erm, so what if you do **not** use plasma-pa? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesl

D22605: Set notifications entry icon size to medium

pino added a comment. In D22605#499051 , @alexde wrote: > I would like to test it and post a screenshot, however I am not able to compile it: > > 1. I cloned the source from the git repository > 2. mkdir plasma-workspace/applets/notificatio

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

pino added a comment. In D22210#498929 , @asturmlechner wrote: > drop translations No need to do that, scripty will take care of it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlech

D22588: [Pager] Don't link kdelibs4support

pino added inline comments. INLINE COMMENTS > shubham wrote in CMakeLists.txt:18 > Could you please remove this or the occurrence below at line 21? In a separate patch, not in this one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22588 To: broulik, #plasma,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

pino added a comment. In D18571#486708 , @ngraham wrote: > I think we need to implement this everywhere, or remove it from the Colors KCM. Indeed, this misfeature ought to be removed from the colors kcm for the reasons stated above. REP

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

pino added inline comments. INLINE COMMENTS > anthonyfieroni wrote in xwindowtasksmodel.cpp:673-675 > That's double lookup in intensive called function, what about > > int idx = d->lastActivated.indexOf(window); > if (idx >= 0) >return d->lastActivated.at(idx); @anthonyfieroni `d->l

D19011: Thunderbolt KCM and KDED module

pino added a comment. In D19011#480594 , @ngraham wrote: > Plasma 5.16 has been released and master is wide open for new features. Can we get this landed in some capacity soon? It would be great to have more testing time. There is alread

D21029: UpdatesPage: Don't try to translate version numbers

pino added a comment. The explanation of this change does not match the code changes: the code never translated the version numbers, but it composed a string showing the version numbers before and after the upgrade. Could it simply be that one of the two (for example `installedVersion`) is

D20933: Increase buffer for cpuinfo

pino added a comment. I don't think that 1024 represents anything here, just the factor to get kibibytes. So just bump the first value to 64, or even 128. What's the size of `/proc/cpuinfo` on your system? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D2093

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

pino added a comment. In D19389#443139 , @davidedmundson wrote: > Sessionbackend.h is not installed. sessionmanagement.h (not sessionbackend.h) is indeed installed, according to your patch. Considering that D20237: Port to new KWorkspace

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

pino added a comment. - loginddbustypes.h requires a license header - SessionBackend needs a d-pointer to minimize BIC changes - I'd move all the SessionBackend subclasses in a private header; they are not exported anyway, so unusable for users of this public library REPOSITORY R120 Pla

D14147: Port from GConf to GSettings

pino added inline comments. INLINE COMMENTS > drosca wrote in gsettingsitem.cpp:42 > qCritical is not hard-fail, that would be qFatal, but don't really see a > reason to abort here in any case. > > It should be at least qWarning though, as qDebug is usually disabled by > default. As I said, t

D14147: Port from GConf to GSettings

pino added inline comments. INLINE COMMENTS > gsettingsitem.cpp:39 > +case G_VARIANT_CLASS_STRING: > +toReturn = QVariant(QString::fromUtf8(g_variant_get_string(gvalue, > NULL))); > +break; nullptr here > gsettingsitem.cpp:42 > +default: > +qCDebug(PLASMAPA()) <

D18571: Add "apply on double-click" feature to most other recent ported KCMs

pino added a comment. -1 for this: - hidden feature - it does not make sense when the general paradigm is OK/Apply/Cancel, so we are teaching users that options are applied only when OK/Apply is pressed (and thus they are left free to play with options as they fit) - if an user accid

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17983 To: pino, apol Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino added a comment. In D17983#388160 , @pino wrote: > Thanks -- which branch should I push this to? `Plasma/5.12`, `Plasma/5.14`, or only `master` for now? ping? REPOSITORY R120 Plasma Workspace BRANCH sni-overlays (branched from

D18394: Add OTP support for openconnect VPN

pino added a comment. Hi Enrique, I'm not a plasma-nm developer, however I provide some tips & hints regarding your patch. Other than what I noted already, there are few more things that apply in general: - make sure to respect the indentation: each level by 4 spaces with no ta

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino added a comment. Thanks -- which branch should I push this to? `Plasma/5.12`, `Plasma/5.14`, or only `master` for now? REPOSITORY R120 Plasma Workspace BRANCH sni-overlays (branched from master) REVISION DETAIL https://phabricator.kde.org/D17983 To: pino, apol Cc: apol, plasma-d

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino added inline comments. INLINE COMMENTS > apol wrote in statusnotifieritemsource.cpp:296 > Can this bit be removed then? No, this is needed for the "overlay by pixmap" case: `overlayNames` is empty (because no overlay name is available), while `overlay` is not null (as read by the pixmap)

D17533: Make the button's purpose more clear

pino added a comment. I'm personally still not convinced about the usage of the bold for questions, as I wrote in an earlier comment. The rest is not up to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To: amantia, #plasma_accessibility, davided

D18018: [Digital Clock] Add ability to change first day of week

pino added inline comments. INLINE COMMENTS > configCalendar.qml:68 > +model.append({ > +text: i18n("Default"), > +value: -1, this needs a context (using i18nc), otherwise translators have no idea what "Default" means REPOSITORY R120 Pl

D17983: StatusItemNotifier: fix overlays by name with icons by name

pino created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. pino requested review of this revision. REVISION SUMMARY Setting an overlay by name results in a QIcon for it created; OTOH, this icon is never used to create the final image in case the main

D17533: Make the button's purpose more clear

pino added a comment. Regarding the use of bold: please note that using bold in some languages (usually eastern ones) either is not possible, or it does not make sense. So please do not solely rely on it to convey anything. INLINE COMMENTS > kaccess.cpp:671 > dialog = new QDialog(n

D17598: Improve "No internet connection!" error message

pino added a comment. The error message is still not optimal (contractions, not correct spelling of "the Internet", etc). "Could not load any application; please verify your network connectivity." REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D1759

D15093: Add WireGuard capability.

pino added a comment. In D15093#328241 , @andersonbruce wrote: > In D15093#327917 , @pino wrote: > > > note there are still few "not done" comments around (eg using QSpinBox for fwMark) > > >

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. note there are still few "not done" comments around (eg using QSpinBox for fwMark) INLINE COMMENTS > CMakeLists.txt:28 > Widgets > +Test > ) already added by D15520: Upgra

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

pino added a comment. - please remove all the empty `initTestCase()` in tests INLINE COMMENTS > simpleiplistvalidator.cpp:27-28 > +SimpleIpListValidator::SimpleIpListValidator(QObject *parent, > + AddressStyle style, > +

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. - same notes for `simpleipv6test.cpp` as in `simpleipv4test.cpp` INLINE COMMENTS > CMakeLists.txt:11-13 > +add_executable(simpleipv6test ${simpleipv6test_SRCS}) > +add_test(simpleipv6

D15521: Add validator for lists of IP addressesAdded as separate review per comment from Pino onreview D15093. This code will not compile withoutthe updated code in review D15520. Also includesunit te

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. - same note as in D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator regarding the commit, and the summary of this review

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. In D15093#324457 , @andersonbruce wrote: > A couple of questions on opening other review requests: > > - Should I open a bug request

D15440: Translated into Russian

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. NACK, this is not the correct approach. The right approach is translate the messages via the .po file that contains them: https://websvn.kde.org/trunk/l10n-kf5/ru/messages/kde-works

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Thanks Bruce for all the updates, and patience! In return, I have more notes :) - I'd send the changes to the existing SimpleIpV4AddressValidator in an own review request, since

D15093: Add WireGuard capability.

pino added a comment. In D15093#319336 , @andersonbruce wrote: > If you as a representative of the plasma-nm philosophy have a preference on which way to go or have a brilliant idea which solves all the problems, I will follow your lead.

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Much better now! General notes: - there are various checks on lengths of strings like `str.length() > 0` or `str.length() != 0`: if all you need is check whether a string is

D15093: Add WireGuard capability.

pino added a comment. In D15093#317960 , @andersonbruce wrote: > I've used KDE for years but this is the first time I've written code using Qt so it doesn't surprise me that I didn't use some of the preferred methods of doing things. I have a f

D15024: Update icons kcm docbook to 5.13

pino added inline comments. INLINE COMMENTS > index.docbook:48 > > + > In this module you can: extra empty line > index.docbook:86 > > -If you dowloaded new themes from the internet, you can use this to browse to > the > -location of those newly downloaded themes. Clicking on this button

D15093: Add WireGuard capability.

pino added a comment. In D15093#315885 , @andersonbruce wrote: > As far as the 'passwordfield' files, this was just laziness on my part, it being easier to just copy them than figure out how to get cmake (another tool I haven't used much) to ad

D15093: Add WireGuard capability.

pino requested changes to this revision. pino added a comment. This revision now requires changes to proceed. Misc notes: - please remove all the translations (i.e. `Name=[lang]` & `Comment[lang]` from desktop/json files, since KDE has an automatic system to handle them - please use KCo

D13772: Add AppStream metadata

pino requested changes to this revision. pino added inline comments. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:11 > +System Guard allows you to monitor information and statistics about > your system. > +In addition to monitoring the local system, it can connect to remote > systems

Re: Review Request 128073: Make Wayland optional

/ Testing --- Builds fine. Thanks, Pino Toscano

Re: Review Request 129731: man: generate gperf output at build time

marked as submitted. Review request for Plasma and Martin Koller. Changes --- Submitted with commit 201bdffd02cd2773dfe8a9e8c5d689020f7b5aee by Pino Toscano to branch master. Repository: kio-extras Description --- Look for gperf, and use it to generate the hash-based lookup for

Review Request 129731: man: generate gperf output at build time

0e9c0ecbdbec1dd03cc7891f0aa8a81eba872b9a man/tests/CMakeLists.txt 9612b648dec868222e0c160d4839150a7fa2916f Diff: https://git.reviewboard.kde.org/r/129731/diff/ Testing --- Builds fine as before, and the gperf output in the build directory matches the removed generated source. Thanks, Pino Toscano

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 20, 2016, 10:46 p.m., Pino Toscano wrote: > > TBH I don't think the Congo and CZ changes are somehow needed, since the > > current names are already the official names for the countries. > > Jiri Bohac wrote: > The reason is consistency. > The

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

not needed. applets/digital-clock/plugin/timezonesi18n.cpp (line 717) <https://git.reviewboard.kde.org/r/129691/#comment67967> Theoretically "Czech Republic" is correct as well, since it's the official name (as also recorded by iso-codes). - Pino Toscano On Dec. 20, 2

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: Review Request 128073: Make Wayland optional

> On June 1, 2016, 8:13 a.m., Martin Gräßlin wrote: > > -2, see also https://bugs.kde.org/show_bug.cgi?id=361954 for explanation > > why we don't want this. > > Pino Toscano wrote: > Nowhere there is discussed (only briefly mentioned) about support with >

Re: Review Request 128073: Make Wayland optional

/128073/#review96120 --- On June 1, 2016, 8:10 a.m., Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128073/ > ---

Review Request 128073: Make Wayland optional

7294d88af127a6604bc7e48e16342c93f152de8c src/doctor/doctor.cpp a156f006212e63c155a6f643929d0a5880275731 tests/CMakeLists.txt 1489d21383e13cd1431a81d48b4a272c28302041 Diff: https://git.reviewboard.kde.org/r/128073/diff/ Testing --- Builds fine. Thanks, Pino Toscano

Re: Review Request 127086: Raise the required CMake version to 3.4.0

the build with older CMake; please check whether it does for you as well. In any case, -1 to this change. - Pino Toscano On Feb. 16, 2016, 11:13 a.m., Elias Probst wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

will change it soon. Thanks for the notice. - Pino --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review92995 --- On Feb. 14,

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

marked as submitted. Review request for Localization and Translation (l10n), Plasma and John Layt. Changes --- Submitted with commit fea67bd2ae7549e88952ac6dbcf90392d0ee1458 by Pino Toscano to branch master. Repository: plasma-workspace Description --- Instead of an hardcoded list

Re: Review Request 126995: Drop usage of Qt4Support

tps://git.reviewboard.kde.org/r/126995/#comment62847> `QFile::encodeName()` is needd in this case. - Pino Toscano On Feb. 5, 2016, 8:25 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

't be extracted anymore. - Pino --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review91552 --- On Gen. 2

Review Request 126879: [digital-clock] Use iso-codes for country names

://git.reviewboard.kde.org/r/126879/diff/ Testing --- With Plasma 5.3 (but this code is the same as in master), the configuration of timezoned in the digital clock is translated according to iso-codes. Thanks, Pino Toscano ___ Plasma-devel mailing list

Re: Review Request 126126: kicker: always show arrows for items with children

--- Thanks, Pino Toscano ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126126: kicker: always show arrows for items with children

> On Nov. 21, 2015, 3:05 p.m., Eike Hein wrote: > > This is intentional because in particular the root menu looks quite ugly > > and busy with all arrows ... > > Pino Toscano wrote: > To me a menu with submenu entries not marked as such (if not when > hovering

Re: Review Request 126126: kicker: always show arrows for items with children

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126126/#review88672 --- On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote: > > -

Review Request 126126: kicker: always show arrows for items with children

becf13d278862b20f46eacae628364708abadfdc Diff: https://git.reviewboard.kde.org/r/126126/diff/ Testing --- Thanks, Pino Toscano ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121761: Fix build on FreeBSD

tps://git.reviewboard.kde.org/r/121761/#comment50723> This (and all the other cases of this) should rather be: ``` #ifdef SIGUNUSED ... #endif ``` so the code using this signal is built when it is available, not just "on Linux/$OS". - Pino Toscano On

Re: KDEREVIEW: share like connect and plasmate

Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: > On 3 January 2013 01:51, Pino Toscano wrote: > > - PasswordAsker sounds like could be implemented on top of > > KPasswordDialog > > we have asked in #kde-devel and we have been informed that > kdia

Re: KDEREVIEW: share like connect and plasmate

Alle giovedì 3 gennaio 2013, Giorgos Tsiapaliokas ha scritto: > On 2 January 2013 23:38, Pino Toscano wrote: > > > - BranchDialog sounds like could be replaced with > > > KInputDialog::getText with a custom validator > > > > Still there. > > > >

Re: KDEREVIEW: share like connect and plasmate

Hi, apparently some people consider that all the issues of this review have been fixed, but really they were not. Alle sabato 3 novembre 2012, Pino Toscano ha scritto: > - PasswordAsker sounds like could be implemented on top of > KPasswordDialog Still there. > - BranchDialog so

Re: KDEREVIEW: share like connect and plasmate

tually understand what I'm referring to? -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDEREVIEW: share like connect and plasmate

Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 4 November 2012 16:55, Pino Toscano wrote: > > - the following binaries are installed in $prefix/bin: > > - plasmaengineexplorer > > - plasmakconfigxteditor > > - plasmaremot

Re: KDEREVIEW: share like connect and plasmate

Hi, Alle lunedì 5 novembre 2012, Giorgos Tsiapaliokas ha scritto: > On 3 November 2012 19:35, Pino Toscano wrote: > > - a numer of .ui files sets bold/bigger texts, but using a qt rich > > text which forces a font size (and in few cases also the font > > face) > > a

Re: KDEREVIEW: share like connect and plasmate

Hi, Alle sabato 3 novembre 2012, Pino Toscano ha scritto: > Alle giovedì 1 novembre 2012, Aaron J. Seigo ha scritto: > > This is to inform everyone that the plasmate and share-like-connect > > repositories have been moved into KDE Review so that, if all goes > > according

Re: KDEREVIEW: share like connect and plasmate

for actions (never ever compare to translated strings, especially when coming from other components) I think that's enough for now. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma

Re: Review Request: KDevelop sessions runner

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100903/#review2079 --- The README file looks... not updated :) runners/kdevelopsessio

Re: Review Request: use portable KDiskFreeSpaceInfo for free space calculation

lasma-devel/2010-June/012027.html - Pino On 2010-06-06 13:15:14, Pino Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboa

Re: Review Request: use portable KDiskFreeSpaceInfo for free space calculation

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4241/ --- (Updated 2010-06-06 13:15:14.345121) Review request for Plasma and Christopher B

Review Request: use portable KDiskFreeSpaceInfo for free space calculation

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4241/ --- Review request for Plasma and Christopher Blauvelt. Summary --- Currently,

Re: Review Request: Update the method name in gps library

> On 2010-01-04 23:20:09, Aaron Seigo wrote: > > deja vu; we had a patch recently that did something similar, except it > > tried some ifdef's. see: > > > > http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp?r1=1023511&r2=1065343 > > > > b

Re: Review Request: support for latex colours in kolorpicker.

l. To reply, visit: > http://reviewboard.kde.org/r/1747/ > --- > > (Updated 2009-09-30 17:30:08) > > > Review request for Plasma and Pino Toscano. > > > Summary > --- > > adds support for latex co

Re: Review Request: Plasma::WindowEffects functions to render window thumbnails

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1800/#review2576 --- /trunk/KDE/kdelibs/plasma/windoweffects.h

Re: Review Request: adding default colors format for kolourpicker and support for latex colors.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1669/#review2508 --- As said also on IRC (after being asked), I'm NOT ok with the all patch

Re: Review Request: windows port of taskmanager library

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1101/#review1881 --- trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp