pino added inline comments. INLINE COMMENTS
> drosca wrote in gsettingsitem.cpp:42 > qCritical is not hard-fail, that would be qFatal, but don't really see a > reason to abort here in any case. > > It should be at least qWarning though, as qDebug is usually disabled by > default. As I said, to better not silently miss new types of keys, as logging to terminal will not help with a GUI application. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: pino, lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
