pino added inline comments.

INLINE COMMENTS

> ListItemBase.qml:357
> +                            if (port.name == "analog-output-speaker" || 
> port.name == "analog-input-microphone-internal") {
> +                                menuItem.text += i18nc("Port is 
> unavailable", " (unavailable)");
> +                            } else {

please avoid i18n puzzles, and use placeholders instead; for example

  i18nc("Port is unavailable", "%1 (unavailable)", port_description);

> ListItemBase.qml:359
> +                            } else {
> +                                menuItem.text += i18nc("Port is unplugged", 
> " (unplugged)");
> +                            }

ditto

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to