pino added a comment.

  - loginddbustypes.h requires a license header
  - SessionBackend needs a d-pointer to minimize BIC changes
  - I'd move all the SessionBackend subclasses in a private header; they are 
not exported anyway, so unusable for users of this public library

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19389

To: davidedmundson, #plasma
Cc: pino, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to