----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101522 -----------------------------------------------------------
TBH I don't think the Congo and CZ changes are somehow needed, since the current names are already the official names for the countries. applets/digital-clock/plugin/timezonesi18n.cpp (line 531) <https://git.reviewboard.kde.org/r/129691/#comment67963> This follows the official name already, not the common name, so the change is not needed. applets/digital-clock/plugin/timezonesi18n.cpp (line 717) <https://git.reviewboard.kde.org/r/129691/#comment67967> Theoretically "Czech Republic" is correct as well, since it's the official name (as also recorded by iso-codes). - Pino Toscano On Dec. 20, 2016, 9:57 p.m., Jiri Bohac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129691/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 9:57 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-workspace > > > Description > ------- > > Update the list of country names to the current names in iso-codes > (as output by isoquery -c). > > The motivation is updating the name of Czechia as a followup to > https://git.reviewboard.kde.org/r/129644/ > As suggested by Albert Astals Cid, fixing the name in i10n is not enough: > country names are hardcoded in many places and they need to be fixed > separately. > > > Diffs > ----- > > applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 > > Diff: https://git.reviewboard.kde.org/r/129691/diff/ > > > Testing > ------- > > > Thanks, > > Jiri Bohac > >
