pino added inline comments. INLINE COMMENTS
> gsettingsitem.cpp:39 > + case G_VARIANT_CLASS_STRING: > + toReturn = QVariant(QString::fromUtf8(g_variant_get_string(gvalue, > NULL))); > + break; nullptr here > gsettingsitem.cpp:42 > + default: > + qCDebug(PLASMAPA()) << "Unhandled variant type in value()"; > + } should this be qCCritical, to hard-fail in case other types of keys are used (instead of silently doing nothing)? > gsettingsitem.cpp:68 > + default: > + qCDebug(PLASMAPA()) << "Unhandled variant type in set()"; > + } as above, qCCritical too? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: pino, lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
