pino added inline comments.

INLINE COMMENTS

> sitter wrote in opengl.cpp:210
> Is that also true for paths that are only ascii? Specifically path is a /dev 
> node.

sure, i get this specific path is ascii

the general recommendation is to use QFile::encodeName for QString -> C paths 
conversions, no matter what (and viceversa QFile::decodeName for C -> QString); 
i personally always use these two avoid any possible future mistake

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27980

To: sitter
Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

Reply via email to