jpountz commented on pull request #588:
URL: https://github.com/apache/lucene/pull/588#issuecomment-1006349216
Feel free to merge this if tests pass and you didn't have to make
significant changes upon backporting. Do we also need to move the CHANGES entry
to a different version on other b
jpountz commented on a change in pull request #578:
URL: https://github.com/apache/lucene/pull/578#discussion_r779353869
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsColle
zacharymorn opened a new pull request #588:
URL: https://github.com/apache/lucene/pull/588
This PR backports bug fix #444 to version `9.1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
zacharymorn opened a new pull request #587:
URL: https://github.com/apache/lucene/pull/587
This PR backports bug fix apache/lucene#444 to version `9.0.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
zacharymorn opened a new pull request #2637:
URL: https://github.com/apache/lucene-solr/pull/2637
This PR backports bug fix https://github.com/apache/lucene/pull/444 to
version `8.11.2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zacharymorn commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r779299155
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/perfield/TestPerFieldKnnVectorsFormat.java
##
@@ -172,9 +171,14 @@ public KnnVectorsWriter f
gf2121 commented on a change in pull request #585:
URL: https://github.com/apache/lucene/pull/585#discussion_r779279138
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -71,17 +71,27 @@ public FastTaxonomyFacetCounts(
[
https://issues.apache.org/jira/browse/LUCENE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley closed LUCENE-6121.
> Fix CachingTokenFilter to propagate reset() the first time
> ---
[
https://issues.apache.org/jira/browse/LUCENE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-6121.
--
Resolution: Fixed
> Fix CachingTokenFilter to propagate reset() the first time
> -
gsmiller commented on pull request #543:
URL: https://github.com/apache/lucene/pull/543#issuecomment-1006175062
@romseygeek I think this PR is ready for another look when you have a
moment. Thanks again for your input!
--
This is an automated message from the Apache Git Service.
To respo
rmuir commented on pull request #586:
URL: https://github.com/apache/lucene/pull/586#issuecomment-1006157404
> I am fine, except the NPEs should have a message.
Why? for users that throw the stacktrace away?
>
> P.S.: And as said maybe require a message always!?
Mayb
[
https://issues.apache.org/jira/browse/LUCENE-10356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469567#comment-17469567
]
Greg Miller commented on LUCENE-10356:
--
[~gf2121] mind having a look at [https://g
gsmiller commented on a change in pull request #578:
URL: https://github.com/apache/lucene/pull/578#discussion_r779174169
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsColl
uschindler commented on pull request #586:
URL: https://github.com/apache/lucene/pull/586#issuecomment-1006113376
The only thing: we should pass the parameter name on NPE (2nd argument of
requireNonNull. This allows to figure out easier which one was wrong for the
caller.
Maybe add
uschindler commented on pull request #586:
URL: https://github.com/apache/lucene/pull/586#issuecomment-1006112599
I switched to 100% null and it now still passes. We should also run one time
with 50% to fuzz some cases where the first parameter is non-null and second is
null.
--
This is
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469557#comment-17469557
]
Greg Miller commented on LUCENE-10151:
--
Just so I don't loose track of this though
uschindler commented on a change in pull request #586:
URL: https://github.com/apache/lucene/pull/586#discussion_r779141374
##
File path:
lucene/analysis.tests/src/test/org/apache/lucene/analysis/tests/TestRandomChains.java
##
@@ -754,6 +758,7 @@ public String toString() {
rmuir commented on a change in pull request #586:
URL: https://github.com/apache/lucene/pull/586#discussion_r779116266
##
File path:
lucene/analysis.tests/src/test/org/apache/lucene/analysis/tests/TestRandomChains.java
##
@@ -754,6 +758,7 @@ public String toString() {
}
[
https://issues.apache.org/jira/browse/LUCENE-10261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10261.
--
Resolution: Not A Problem
> Preset/ custom analyzer pipelines in Luke won't work with the mod
rmuir opened a new pull request #586:
URL: https://github.com/apache/lucene/pull/586
10% of the time, TestRandomChains will pass `null` to any object parameters
in analyzers' ctors.
We allow NPE from the ctor, so it enforces the analyzers check up front.
It just means we have to r
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10328.
--
Resolution: Fixed
> Module path for compiling and running tests is wrong
> --
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469529#comment-17469529
]
ASF subversion and git services commented on LUCENE-10328:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reopened LUCENE-10328:
--
Reopen for manual backporting to 9x.
> Module path for compiling and running tests is wrong
> --
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469515#comment-17469515
]
ASF subversion and git services commented on LUCENE-10328:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10328.
--
Fix Version/s: 9.1
Resolution: Fixed
> Module path for compiling and running tests is
dweiss merged pull request #571:
URL: https://github.com/apache/lucene/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
mcimadamore edited a comment on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1005995125
> From what I have learned, copy operations have high overhead because:
>
> * they are not hot, so aren't optimized so fast
>
> * when not optimized
mcimadamore commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1005995125
> From what I have learned, copy operations have high overhead because:
>
> * they are not hot, so aren't optimized so fast
>
> * when not optimized, the s
gsmiller commented on a change in pull request #585:
URL: https://github.com/apache/lucene/pull/585#discussion_r779026781
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -91,31 +101,36 @@ private final void count(List mat
gsmiller commented on pull request #585:
URL: https://github.com/apache/lucene/pull/585#issuecomment-1005949811
Maybe a very small improvement with this change, but nothing particularly
impactful. I wonder how often we actually trigger this case in our benchmarks?
Certainly not as often as
jtibshirani commented on a change in pull request #583:
URL: https://github.com/apache/lucene/pull/583#discussion_r779026136
##
File path: lucene/core/src/java/org/apache/lucene/codecs/FieldsProducer.java
##
@@ -42,6 +45,14 @@ protected FieldsProducer() {}
*/
public abst
gsmiller opened a new pull request #585:
URL: https://github.com/apache/lucene/pull/585
# Description
Facet implementations have seen performance improvements by unwrapping
singleton doc values for situations where the underlying field is actually
single-valued. This change adds the
[
https://issues.apache.org/jira/browse/LUCENE-10354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469457#comment-17469457
]
ASF subversion and git services commented on LUCENE-10354:
--
Co
jpountz merged pull request #583:
URL: https://github.com/apache/lucene/pull/583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
uschindler edited a comment on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005928057
To conclude here: I was already thinking several times during the module
system devlopment that it might be a good idea to have some pattern in
forbidden/errorprone/...
uschindler edited a comment on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005928057
To conclude here: I was already thinking several times during the module
system devlopment that it might be a good idea to have some pattern in
forbidden/errorprone/...
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005928057
To conclude here: I was already thinking several times during the module
system devlopment that it might be a good idea to have some pattern in
forbidden/errorprone/... that de
dweiss commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1005918864
> The depenendecies are always modular, so lucene.core is put on
module-path, even so we are running tests in classpath mode. This is waht this
PR mainly changes, correct? reviousl
dweiss commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778993450
##
File path: gradle/java/modules.gradle
##
@@ -27,194 +29,167 @@ allprojects {
modularity.inferModulePath.set(false)
}
-// Map convention c
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r778990326
##
File path: lucene/core/src/java/org/apache/lucene/util/RamUsageEstimator.java
##
@@ -584,9 +585,13 @@ public static long shallowSizeOfInstance(Class cl
gf2121 commented on a change in pull request #545:
URL: https://github.com/apache/lucene/pull/545#discussion_r778988719
##
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/ForUtil.java
##
@@ -1051,4 +1052,76 @@ private static void decode24(DataInput in, long[]
uschindler edited a comment on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005906362
> > Thanks for the pointer, Robert. I wonder what the "acceptable level"
criteria are. ;)
>
> I wonder too, i searched some commonly used java libraries mainline
uschindler edited a comment on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005906362
> > Thanks for the pointer, Robert. I wonder what the "acceptable level"
criteria are. ;)
>
> I wonder too, i searched some commonly used java libraries mainline
gf2121 commented on pull request #545:
URL: https://github.com/apache/lucene/pull/545#issuecomment-1005906911
Thanks @jpountz ! This is indeed making codes harder to read. I tried to
make all these complex constants generated from script, keeping `ForUtil.java`
clean. How does it look now?
uschindler commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005906362
> > Thanks for the pointer, Robert. I wonder what the "acceptable level"
criteria are. ;)
>
> I wonder too, i searched some commonly used java libraries mainline
branche
[
https://issues.apache.org/jira/browse/LUCENE-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-4983:
--
Labels: random-chains (was: )
> CommonGramsFilter assumes all input tokens have a length of 1
[
https://issues.apache.org/jira/browse/LUCENE-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-6121:
--
Labels: random-chains (was: )
> Fix CachingTokenFilter to propagate reset() the first time
>
[
https://issues.apache.org/jira/browse/LUCENE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-8092:
--
Labels: random-chains (was: )
> TestRandomChains failure
>
>
>
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10352:
---
Labels: random-chains (was: )
> Convert TestAllAnalyzersHaveFactories and TestRandomChains
[
https://issues.apache.org/jira/browse/LUCENE-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10362:
---
Labels: random-chains (was: )
> JapaneseNumberFilter messes up offsets
> -
[
https://issues.apache.org/jira/browse/LUCENE-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10363:
---
Labels: random-chains (was: )
> JapaneseCompletionFilter messes up offsets
> -
[
https://issues.apache.org/jira/browse/LUCENE-10361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10361:
---
Labels: random-chains (was: )
> KoreanNumberFilter messes up offsets
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10360:
---
Labels: random-chains (was: )
> BeiderMorseFilter: TestRandomChains fails with IndexOutOfB
[
https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10353:
---
Labels: random-chains (was: )
> Add null injection to analyzer integration tests (e.g. Tes
[
https://issues.apache.org/jira/browse/LUCENE-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10358:
---
Labels: random-chains (was: )
> JapaneseIterationMarkCharFilter: TestRandomChains fails wi
[
https://issues.apache.org/jira/browse/LUCENE-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10359:
---
Labels: random-chains (was: )
> KoreanTokenizer: TestRandomChains fails with incorrect off
magibney commented on pull request #380:
URL: https://github.com/apache/lucene/pull/380#issuecomment-1005887111
Apologies for the delay, and thanks for bearing with me, @spyk. I'm inclined
to err on the cautious side with this, since I'm not as familiar with this part
of the codebase or th
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469420#comment-17469420
]
Cameron VandenBerg commented on LUCENE-10157:
-
Hi Adrien, it makes sense to
msokolov commented on pull request #536:
URL: https://github.com/apache/lucene/pull/536#issuecomment-1005868557
Thanks for the thorough testing, @mayya-sharipova. I think we want to
minimize heap usage, the index size cost is small; basically we are trading off
on-heap for on-disk/off-heap
jpountz commented on pull request #444:
URL: https://github.com/apache/lucene/pull/444#issuecomment-1005865609
Correct, changes should no longer be backported to `branch_8x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778933921
##
File path: gradle/java/modules.gradle
##
@@ -27,194 +29,167 @@ allprojects {
modularity.inferModulePath.set(false)
}
-// Map conventi
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469399#comment-17469399
]
Adrien Grand commented on LUCENE-10157:
---
Hi Cameron, the sandbox is actually part
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778925282
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -57,7 +57,7 @@ allprojects {
outputDir = project.javadoc.destinationDir
}
-
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778931152
##
File path: gradle/java/modules.gradle
##
@@ -27,194 +29,167 @@ allprojects {
modularity.inferModulePath.set(false)
}
-// Map conventi
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778930571
##
File path: gradle/java/modules.gradle
##
@@ -27,194 +29,167 @@ allprojects {
modularity.inferModulePath.set(false)
}
-// Map conventi
mayya-sharipova commented on pull request #536:
URL: https://github.com/apache/lucene/pull/536#issuecomment-1005844307
I've also run the comparison on a bigger dataset: deep-image-96-angular of
10M docs.
M: 16; efConstruction: 500
Disk size before the change: 4.2G; after change: 4
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778926381
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -57,7 +57,7 @@ allprojects {
outputDir = project.javadoc.destinationDir
}
-
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778924772
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -57,7 +57,7 @@ allprojects {
outputDir = project.javadoc.destinationDir
}
-
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1005839073
I think you have to solve the conflicts caused by the change for running
"gradlew beast". I leave that up to you. Maybe it works better after this
branch is merged.
--
This
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778922786
##
File path: gradle/java/modules.gradle
##
@@ -27,194 +29,167 @@ allprojects {
modularity.inferModulePath.set(false)
}
-// Map conventi
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469393#comment-17469393
]
Cameron VandenBerg commented on LUCENE-10157:
-
Hi [~jpountz], I would reall
uschindler commented on a change in pull request #571:
URL: https://github.com/apache/lucene/pull/571#discussion_r778921454
##
File path: gradle/java/modules.gradle
##
@@ -27,194 +29,167 @@ allprojects {
modularity.inferModulePath.set(false)
}
-// Map conventi
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469392#comment-17469392
]
ASF subversion and git services commented on LUCENE-10291:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469388#comment-17469388
]
ASF subversion and git services commented on LUCENE-10291:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469391#comment-17469391
]
ASF subversion and git services commented on LUCENE-10291:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10291.
---
Fix Version/s: 9.1
Resolution: Fixed
> Only read/write postings when there is at lea
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469390#comment-17469390
]
ASF subversion and git services commented on LUCENE-10291:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469389#comment-17469389
]
ASF subversion and git services commented on LUCENE-10291:
--
Co
uschindler commented on pull request #571:
URL: https://github.com/apache/lucene/pull/571#issuecomment-1005827412
> Please take a look at this comment/ chart, Uwe.
https://issues.apache.org/jira/browse/LUCENE-10328?focusedCommentId=17468676&page=com.atlassian.jira.plugin.system.issuetabpane
ywelsch commented on pull request #539:
URL: https://github.com/apache/lucene/pull/539#issuecomment-1005809668
Thanks @jpountz!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469383#comment-17469383
]
ASF subversion and git services commented on LUCENE-10291:
--
Co
jpountz merged pull request #539:
URL: https://github.com/apache/lucene/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469380#comment-17469380
]
Adrien Grand commented on LUCENE-10157:
---
If you don't mind, I would like to move
rmuir commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005769579
> Thanks for the pointer, Robert. I wonder what the "acceptable level"
criteria are. ;)
I wonder too, i searched some commonly used java libraries mainline branches
(`guava`,
dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005762127
Thanks for the pointer, Robert. I wonder what the "acceptable level"
criteria are. ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/LUCENE-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10343.
---
Fix Version/s: 9.1
Resolution: Fixed
> Remove MyRandom in favor of test framework ra
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r778884007
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/HardlinkCopyDirectoryWrapper.java
##
@@ -66,7 +67,7 @@ public void copyFrom(Directory fro
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r778883566
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/HardlinkCopyDirectoryWrapper.java
##
@@ -66,7 +67,7 @@ public void copyFrom(Directory fro
[
https://issues.apache.org/jira/browse/LUCENE-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469370#comment-17469370
]
ASF subversion and git services commented on LUCENE-10343:
--
Co
jpountz merged pull request #529:
URL: https://github.com/apache/lucene/pull/529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
rmuir commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005755345
I don't think the code is going to stop compiling, instead you will just
"lose protection"?
> In Java 18 and later, we will degrade other Security Manager APIs so that
they
jpountz merged pull request #525:
URL: https://github.com/apache/lucene/pull/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
uschindler commented on a change in pull request #579:
URL: https://github.com/apache/lucene/pull/579#discussion_r778881181
##
File path:
lucene/core/src/java/org/apache/lucene/util/LegacySecurityManager.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundati
jpountz commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r778880348
##
File path:
lucene/core/src/test/org/apache/lucene/codecs/perfield/TestPerFieldKnnVectorsFormat.java
##
@@ -172,9 +171,14 @@ public KnnVectorsWriter field
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10352.
Fix Version/s: 9.1
10.0 (main)
Resolution: Fixed
We opened seve
jpountz commented on pull request #541:
URL: https://github.com/apache/lucene/pull/541#issuecomment-1005745531
Nice. I wonder if we need to specialize for so many numbers of bits per
value like we do for postings, or if we should only specialize for a few
numbers of bits per value that are
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469362#comment-17469362
]
ASF subversion and git services commented on LUCENE-10352:
--
Co
dweiss commented on pull request #579:
URL: https://github.com/apache/lucene/pull/579#issuecomment-1005744351
I do have the same concerns but at the same time - if they remove the
security manager entirely in, say, JDK 17+X then the code will stop compiling/
working anyway. Maybe these con
[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469354#comment-17469354
]
ASF subversion and git services commented on LUCENE-10352:
--
Co
jpountz commented on pull request #545:
URL: https://github.com/apache/lucene/pull/545#issuecomment-1005739072
I'm a bit torn as this also makes the code harder to read with all these
constants with complex names.
--
This is an automated message from the Apache Git Service.
To respond to
1 - 100 of 162 matches
Mail list logo
