rmuir opened a new pull request #586:
URL: https://github.com/apache/lucene/pull/586
10% of the time, TestRandomChains will pass `null` to any object parameters
in analyzers' ctors.
We allow NPE from the ctor, so it enforces the analyzers check up front.
It just means we have to run the test in a loop:
```
./gradlew :lucene:analysis.tests:beast -Dtests.dups=100 --tests
TestRandomChains -Dtests.nightly=true
```
and add missing `Objects.requireNonNull()` to the bugs that it finds at
runtime.
Example fail:
```
> java.lang.NullPointerException: Cannot invoke
"org.apache.lucene.analysis.compound.hyphenation.HyphenationTree.hyphenate(char[],
int, int, int, int)" because "this.hyphenator" is null
> at
__randomizedtesting.SeedInfo.seed([29B8EF94FA5640A3:1459C6F5BD445D63]:0)
> at
org.apache.lucene.analysis.common@10.0.0-SNAPSHOT/org.apache.lucene.analysis.compound.HyphenationCompoundWordTokenFilter.decompose(HyphenationCompoundWordTokenFilter.java:143)
> at
org.apache.lucene.analysis.common@10.0.0-SNAPSHOT/org.apache.lucene.analysis.compound.CompoundWordTokenFilterBase.incrementToken(CompoundWordTokenFilterBase.java:115)
```
See issue: https://issues.apache.org/jira/browse/LUCENE-10353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
