gsmiller commented on a change in pull request #585:
URL: https://github.com/apache/lucene/pull/585#discussion_r779026781
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##########
@@ -91,31 +101,36 @@ private final void count(List<MatchingDocs> matchingDocs)
throws IOException {
private final void countAll(IndexReader reader) throws IOException {
for (LeafReaderContext context : reader.leaves()) {
- SortedNumericDocValues dv =
context.reader().getSortedNumericDocValues(indexFieldName);
- if (dv == null) {
+ SortedNumericDocValues multiValued =
Review comment:
I took the liberty to suggest renaming variables here for consistency
with other faceting implementations that do this and for slightly improved
readability (IMO anyway).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
