rmuir commented on a change in pull request #586:
URL: https://github.com/apache/lucene/pull/586#discussion_r779116266
##########
File path:
lucene/analysis.tests/src/test/org/apache/lucene/analysis/tests/TestRandomChains.java
##########
@@ -754,6 +758,7 @@ public String toString() {
} catch (InvocationTargetException ite) {
final Throwable cause = ite.getCause();
if (cause instanceof IllegalArgumentException
+ || cause instanceof NullPointerException
Review comment:
If we can tighten this logic to be `(cause instanceof
NullPointerException && weProvidedANullArg)`, I think it would be better. then
the test wouldn't mask bugs (internal NPEs) that happen for situations where we
passed the ctor all non-null arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
