jpountz commented on a change in pull request #578:
URL: https://github.com/apache/lucene/pull/578#discussion_r779353869
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##########
@@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsCollector fc,
TaxonomyReader taxoReader) {
return sumTotalHits < maxDoc / 10;
}
- /** Increment the count for this ordinal by 1. */
- protected void increment(int ordinal) {
Review comment:
@gsmiller I wonder if we should reconsider the backward-compatibility
guarantees of the faceting APIs. Except for APIs that are really meant for end
users to extend like analysis components, my understanding is that we usually
consider overriding of our own classes expert usage that is not subject to
backward compatibility (as opposed to direct usage of these classes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
