zacharymorn commented on a change in pull request #534:
URL: https://github.com/apache/lucene/pull/534#discussion_r779299155
##########
File path:
lucene/core/src/test/org/apache/lucene/codecs/perfield/TestPerFieldKnnVectorsFormat.java
##########
@@ -172,9 +171,14 @@ public KnnVectorsWriter fieldsWriter(SegmentWriteState
state) throws IOException
KnnVectorsWriter writer = delegate.fieldsWriter(state);
return new KnnVectorsWriter() {
@Override
- public void writeField(FieldInfo fieldInfo, VectorValues values)
throws IOException {
+ public void writeField(FieldInfo fieldInfo, KnnVectorsReader
knnVectorsReader)
+ throws IOException {
fieldsWritten.add(fieldInfo.name);
- writer.writeField(fieldInfo, values);
+ // assert that knnVectorsReader#getVectorValues returns different
instances upon repeated
+ // calls
Review comment:
Ah right. I've moved it to `AssertingKnnVectorsReader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
