uschindler commented on pull request #586: URL: https://github.com/apache/lucene/pull/586#issuecomment-1006113376
The only thing: we should pass the parameter name on NPE (2nd argument of requireNonNull. This allows to figure out easier which one was wrong for the caller. Maybe add a check in the random chains fuzzer to require a message on the exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org