[jira] [Comment Edited] (SOLR-13998) Add thread safety annotation to classes

2020-08-11 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176075#comment-17176075 ] Anshum Gupta edited comment on SOLR-13998 at 8/12/20, 6:56 AM:

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

2020-08-11 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176075#comment-17176075 ] Anshum Gupta commented on SOLR-13998: - [~marcussorealheis] - The idea behind this cam

[jira] [Commented] (SOLR-14726) Streamline getting started experience

2020-08-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176071#comment-17176071 ] Jan Høydahl commented on SOLR-14726: cURL is the "default", so probably what we shoul

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176070#comment-17176070 ] Dawid Weiss commented on LUCENE-9448: - I added a pull request this time - removed So

[jira] [Updated] (SOLR-14726) Streamline getting started experience

2020-08-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14726: --- Attachment: yasa-http.png > Streamline getting started experience > -

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-11 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176068#comment-17176068 ] Marcus Eagan commented on LUCENE-8626: -- Great ideas [~dweiss] and [~dsmiley]! > st

[GitHub] [lucene-solr] dweiss opened a new pull request #1742: Standalone distribution assembly for Luke

2020-08-11 Thread GitBox
dweiss opened a new pull request #1742: URL: https://github.com/apache/lucene-solr/pull/1742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1732: Clean up many small fixes

2020-08-11 Thread GitBox
dweiss commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r469031590 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java ## @@ -440,7 +440,7 @@ public static final SegmentInfos readCommit(Directo

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1732: Clean up many small fixes

2020-08-11 Thread GitBox
dweiss commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r469027938 ## File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java ## @@ -367,12 +367,12 @@ public void close() { /** * Original so

[jira] [Commented] (SOLR-13998) Add thread safety annotation to classes

2020-08-11 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176031#comment-17176031 ] Marcus Eagan commented on SOLR-13998: - Hi [~anshum] I'm working on some janitorial wo

[jira] [Commented] (LUCENE-8626) standardise test class naming

2020-08-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176013#comment-17176013 ] David Smiley commented on LUCENE-8626: -- I request that the Solr side be delayed som

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176006#comment-17176006 ] Tomoko Uchida commented on SOLR-13412: -- FYI: I opened LUCENE-9459 to make getting st

[jira] [Updated] (LUCENE-9459) "Getting Started" guide for Luke

2020-08-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-9459: -- Description: While Luke has been very popular, widely accepted tool to Lucene users (includin

[jira] [Created] (LUCENE-9459) "Getting Started" guide for Luke

2020-08-11 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-9459: - Summary: "Getting Started" guide for Luke Key: LUCENE-9459 URL: https://issues.apache.org/jira/browse/LUCENE-9459 Project: Lucene - Core Issue Type: Impro

[GitHub] [lucene-solr] CaoManhDat commented on a change in pull request #1724: SOLR-14684: CloudExitableDirectoryReaderTest failing about 25% of the time

2020-08-11 Thread GitBox
CaoManhDat commented on a change in pull request #1724: URL: https://github.com/apache/lucene-solr/pull/1724#discussion_r468970705 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBSolrClient.java ## @@ -155,6 +159,7 @@ public ServerIterator(Req req, Map z

[jira] [Created] (SOLR-14730) Build new SolrJ APIs without concrete classes like NamedList/Map

2020-08-11 Thread Noble Paul (Jira)
Noble Paul created SOLR-14730: - Summary: Build new SolrJ APIs without concrete classes like NamedList/Map Key: SOLR-14730 URL: https://issues.apache.org/jira/browse/SOLR-14730 Project: Solr Issu

[jira] [Updated] (SOLR-14730) Build new SolrJ APIs without concrete classes like NamedList/Map

2020-08-11 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14730: -- Labels: clean-api (was: ) > Build new SolrJ APIs without concrete classes like NamedList/Map > ---

[jira] [Comment Edited] (SOLR-14687) Make child/parent query parsers natively aware of _nest_path_

2020-08-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175086#comment-17175086 ] Chris M. Hostetter edited comment on SOLR-14687 at 8/12/20, 12:32 AM: -

[jira] [Commented] (SOLR-14677) DIH doesnt close DataSource when import encounters errors

2020-08-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175901#comment-17175901 ] Jason Gerlowski commented on SOLR-14677: I created a PR a few minutes ago that en

[GitHub] [lucene-solr] gerlowskija opened a new pull request #1741: SOLR-14677: Always close DIH EntityProcessor/DataSource

2020-08-11 Thread GitBox
gerlowskija opened a new pull request #1741: URL: https://github.com/apache/lucene-solr/pull/1741 # Description Prior to this commit, the wrapup logic at the end of DocBuilder.execute() closed out a series of DIH objects, but did so in a way that an exception closing any of them

[jira] [Assigned] (SOLR-14677) DIH doesnt close DataSource when import encounters errors

2020-08-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-14677: -- Assignee: Jason Gerlowski > DIH doesnt close DataSource when import encounters errors

[GitHub] [lucene-solr] dsmiley opened a new pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-08-11 Thread GitBox
dsmiley opened a new pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740 Can happen with catenateAll and not generating word xor number part when the input ends with the non-generated sub-token. https://issues.apache.org/jira/browse/LUCENE-9458 CC @jimczi

[jira] [Created] (LUCENE-9458) WordDelimiterGraphFilter (and non-graph) should tie-break order using end offset

2020-08-11 Thread David Smiley (Jira)
David Smiley created LUCENE-9458: Summary: WordDelimiterGraphFilter (and non-graph) should tie-break order using end offset Key: LUCENE-9458 URL: https://issues.apache.org/jira/browse/LUCENE-9458 Proj

[jira] [Commented] (SOLR-14706) Upgrading 8.6.0 to 8.6.1 causes collection creation to fail

2020-08-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175844#comment-17175844 ] ASF subversion and git services commented on SOLR-14706: Commit d

[GitHub] [lucene-solr] HoustonPutman merged pull request #1739: SOLR-14706: Fix support for default autoscaling policy (8x forward-port)

2020-08-11 Thread GitBox
HoustonPutman merged pull request #1739: URL: https://github.com/apache/lucene-solr/pull/1739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (SOLR-14729) Investigate and harden TestExportWriter.testExpr failures

2020-08-11 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-14729: - Summary: Investigate and harden TestExportWriter.testExpr failures Key: SOLR-14729 URL: https://issues.apache.org/jira/browse/SOLR-14729 Project: Solr Issu

[jira] [Commented] (SOLR-13807) Caching for term facet counts

2020-08-11 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175836#comment-17175836 ] Michael Gibney commented on SOLR-13807: --- After SOLR-13132 was merged to master, it

[jira] [Created] (LUCENE-9457) Why is Kuromoji tokenization throughput bimodal?

2020-08-11 Thread Michael McCandless (Jira)
Michael McCandless created LUCENE-9457: -- Summary: Why is Kuromoji tokenization throughput bimodal? Key: LUCENE-9457 URL: https://issues.apache.org/jira/browse/LUCENE-9457 Project: Lucene - Core

[jira] [Updated] (SOLR-13807) Caching for term facet counts

2020-08-11 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-13807: -- Attachment: SOLR-13807-benchmarks.tgz > Caching for term facet counts > ---

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-08-11 Thread GitBox
mikemccand commented on a change in pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r468812527 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -323,8 +323,10 @@ public FacetLa

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-08-11 Thread GitBox
mikemccand commented on a change in pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r468808904 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java ## @@ -323,8 +323,10 @@ public FacetLa

[jira] [Commented] (SOLR-13972) Insecure Solr should generate startup warning

2020-08-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175803#comment-17175803 ] Jason Gerlowski commented on SOLR-13972: Reopening based on the mailing list thre

[jira] [Updated] (SOLR-13972) Insecure Solr should generate startup warning

2020-08-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-13972: --- Status: Reopened (was: Closed) > Insecure Solr should generate startup warning > ---

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #1739: SOLR-14706: Fix support for default autoscaling policy (8x forward-port)

2020-08-11 Thread GitBox
HoustonPutman opened a new pull request #1739: URL: https://github.com/apache/lucene-solr/pull/1739 forward-porting #1716 for https://issues.apache.org/jira/browse/SOLR-14706 This is an automated message from the Apache Git S

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-11 Thread GitBox
jimczi commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r468774381 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldValueHitQueue.java ## @@ -160,18 +160,20 @@ private FieldValueHitQueue(SortField[] fie

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175750#comment-17175750 ] Tomoko Uchida commented on SOLR-13412: -- [~epugh] : {quote}I think that the real issu

[GitHub] [lucene-solr] madrob commented on a change in pull request #1726: SOLR-14722: timeAllowed should track from req creation

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1726: URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468762245 ## File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java ## @@ -67,8 +69,21 @@ public boolean shouldExit() { } /** -

[GitHub] [lucene-solr] atris commented on a change in pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-11 Thread GitBox
atris commented on a change in pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468756781 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -811,10 +818,18 @@ private void initLibs(SolrResourceLoader loader, boolean

[GitHub] [lucene-solr] uschindler commented on pull request #1593: LUCENE-9409: Check file lengths before creating slices.

2020-08-11 Thread GitBox
uschindler commented on pull request #1593: URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-672106735 I am fine to fix the test. Sure you have to first figure out why the index is out of bounds, and the exact exception may be misleading, but that's actually what's happeni

[GitHub] [lucene-solr] atris merged pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
atris merged pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene-solr] jpountz commented on pull request #1593: LUCENE-9409: Check file lengths before creating slices.

2020-08-11 Thread GitBox
jpountz commented on pull request #1593: URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-672097226 I repurposed this PR to instead make the test expect out-of-bounds exceptions. Does it look better to you @rmuir @uschindler ? -

[jira] [Comment Edited] (LUCENE-9379) Directory based approach for index encryption

2020-08-11 Thread Rajeswari Natarajan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175699#comment-17175699 ] Rajeswari Natarajan edited comment on LUCENE-9379 at 8/11/20, 4:59 PM: ---

[GitHub] [lucene-solr] atris commented on a change in pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-11 Thread GitBox
atris commented on a change in pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468728850 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene-solr] atris commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
atris commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468727485 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -48,7 +47,7 @@ public static void setupCluster() throws Exce

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-08-11 Thread Rajeswari Natarajan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175699#comment-17175699 ] Rajeswari Natarajan commented on LUCENE-9379: - [~bruno.roustant] and [~dsmil

[GitHub] [lucene-solr] madrob commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468724755 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -66,20 +65,19 @@ public void testConcurrentQueries() throws

[GitHub] [lucene-solr] madrob commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468721648 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -48,7 +47,7 @@ public static void setupCluster() throws Exc

[GitHub] [lucene-solr] dsmiley merged pull request #1735: LUCENE spell: Implement SuggestWord.toString

2020-08-11 Thread GitBox
dsmiley merged pull request #1735: URL: https://github.com/apache/lucene-solr/pull/1735 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob commented on a change in pull request #1728: SOLR-14596: equals/hashCode for common SolrRequest classes

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1728: URL: https://github.com/apache/lucene-solr/pull/1728#discussion_r468716670 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java ## @@ -244,6 +247,8 @@ public String getBasePath() { public void add

[GitHub] [lucene-solr] madrob commented on a change in pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468711266 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [lucene-solr] atris commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
atris commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468713194 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -66,20 +65,19 @@ public void testConcurrentQueries() throws

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1726: SOLR-14722: timeAllowed should track from req creation

2020-08-11 Thread GitBox
dsmiley commented on a change in pull request #1726: URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468710559 ## File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java ## @@ -67,8 +69,21 @@ public boolean shouldExit() { } /** -

[GitHub] [lucene-solr] atris commented on a change in pull request #1726: SOLR-14722: timeAllowed should track from req creation

2020-08-11 Thread GitBox
atris commented on a change in pull request #1726: URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468709958 ## File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java ## @@ -67,8 +69,21 @@ public boolean shouldExit() { } /** -

[GitHub] [lucene-solr] madrob commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468709509 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -66,20 +65,19 @@ public void testConcurrentQueries() throws

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1726: SOLR-14722: timeAllowed should track from req creation

2020-08-11 Thread GitBox
dsmiley commented on a change in pull request #1726: URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468709003 ## File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java ## @@ -67,8 +69,21 @@ public boolean shouldExit() { } /** -

[jira] [Commented] (LUCENE-9448) Make an equivalent to Ant's "run" target for Luke module

2020-08-11 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175661#comment-17175661 ] Tomoko Uchida commented on LUCENE-9448: --- Thank you [~dweiss] for your help.  {quot

[jira] [Created] (LUCENE-9456) Stored fields should store the number of chunks in the meta file

2020-08-11 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-9456: Summary: Stored fields should store the number of chunks in the meta file Key: LUCENE-9456 URL: https://issues.apache.org/jira/browse/LUCENE-9456 Project: Lucene - Co

[GitHub] [lucene-solr] atris commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
atris commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468681532 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -66,15 +66,11 @@ public void testConcurrentQueries() throws

[jira] [Resolved] (LUCENE-9453) DocumentWriterFlushControl missing explicit sync on write

2020-08-11 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9453. --- Fix Version/s: master (9.0) Lucene Fields: (was: New) Assignee: Mike Drob Resol

[jira] [Commented] (LUCENE-9453) DocumentWriterFlushControl missing explicit sync on write

2020-08-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175651#comment-17175651 ] ASF subversion and git services commented on LUCENE-9453: - Commi

[GitHub] [lucene-solr] madrob merged pull request #1734: LUCENE-9453 Add sync around volatile write

2020-08-11 Thread GitBox
madrob merged pull request #1734: URL: https://github.com/apache/lucene-solr/pull/1734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] gautamworah96 commented on pull request #1733: LUCENE-9450 Use BinaryDocValues in the taxonomy writer

2020-08-11 Thread GitBox
gautamworah96 commented on pull request #1733: URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-672021513 Changes in this revision (incorporated from feedback on JIRA): * Added a call to `advanceExact()` before calling `.binaryValue()` and an `assert` to check that t

[jira] [Resolved] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14727. --- Fix Version/s: 8.7 Resolution: Fixed > Add gradle files to the 8x .gitignore file. > -

[jira] [Commented] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175633#comment-17175633 ] ASF subversion and git services commented on SOLR-14727: Commit 7

[jira] [Updated] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14727: -- Attachment: (was: SOLR-14727.patch) > Add gradle files to the 8x .gitignore file. > ---

[jira] [Updated] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14727: -- Attachment: SOLR-14727.patch > Add gradle files to the 8x .gitignore file. > --

[jira] [Updated] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14727: -- Description: This is a little different than I thought. Apparently it's an interaction with In

[jira] [Updated] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14727: -- Attachment: SOLR-14727.patch > Add gradle files to the 8x .gitignore file. > --

[jira] [Updated] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated SOLR-14727: -- Description: This is a little different than I thought. Apparently it's an interaction with In

[GitHub] [lucene-solr] madrob commented on a change in pull request #1732: Clean up many small fixes

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468631394 ## File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java ## @@ -440,7 +440,7 @@ public static final SegmentInfos readCommit(Directo

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-11 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175609#comment-17175609 ] Erick Erickson commented on SOLR-13412: --- [~dweiss] Yes, I saw that. My take at this

[GitHub] [lucene-solr] madrob commented on a change in pull request #1732: Clean up many small fixes

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468622877 ## File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java ## @@ -367,12 +367,12 @@ public void close() { /** * Original so

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-11 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175606#comment-17175606 ] David Eric Pugh commented on SOLR-13412: I've been following this conversation, a

[jira] [Resolved] (SOLR-14650) Default autoscaling policy rules are ineffective

2020-08-11 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-14650. --- Fix Version/s: (was: 8.7) Resolution: Abandoned The default autoscaling policy has

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2020-08-11 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175583#comment-17175583 ] Bruno Roustant commented on LUCENE-9379: [~Raji] maybe a better approach would b

[jira] [Updated] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-08-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14728: -- Description: A simple optimization can be put in place to massively improve join performance wh

[jira] [Updated] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-08-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14728: -- Description: A simple optimization can be put in place to massively improve join performance wh

[jira] [Created] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-08-11 Thread David Smiley (Jira)
David Smiley created LUCENE-9455: Summary: ExitableTermsEnum (in ExitableDirectoryReader) should sample next() Key: LUCENE-9455 URL: https://issues.apache.org/jira/browse/LUCENE-9455 Project: Lucene -

[jira] [Updated] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-08-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14728: -- Description: A simple optimization that can be put in place to massively improve join performan

[jira] [Resolved] (SOLR-14692) JSON Facet "join" domain should take optional "method" property

2020-08-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-14692. Fix Version/s: 8.7 master (9.0) Assignee: Jason Gerlowski

[jira] [Updated] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-08-11 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14728: -- Description: A simple strategy can be put in place to massively improve join performance when t

[jira] [Created] (SOLR-14728) Add self join optimization to the TopLevelJoinQuery

2020-08-11 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-14728: - Summary: Add self join optimization to the TopLevelJoinQuery Key: SOLR-14728 URL: https://issues.apache.org/jira/browse/SOLR-14728 Project: Solr Issue Type

[jira] [Commented] (SOLR-14692) JSON Facet "join" domain should take optional "method" property

2020-08-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175544#comment-17175544 ] ASF subversion and git services commented on SOLR-14692: Commit d

[jira] [Created] (SOLR-14727) Add gradle files to the 8x .gitignore file.

2020-08-11 Thread Erick Erickson (Jira)
Erick Erickson created SOLR-14727: - Summary: Add gradle files to the 8x .gitignore file. Key: SOLR-14727 URL: https://issues.apache.org/jira/browse/SOLR-14727 Project: Solr Issue Type: Improv

[jira] [Commented] (SOLR-13412) Make the Lucene Luke module available from a Solr distribution

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175528#comment-17175528 ] Dawid Weiss commented on SOLR-13412: bq. My current thinking is that if the stand-alo

[GitHub] [lucene-solr] madrob commented on a change in pull request #1736: Harden RequestRateLimiter Tests

2020-08-11 Thread GitBox
madrob commented on a change in pull request #1736: URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468542925 ## File path: solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java ## @@ -66,15 +66,11 @@ public void testConcurrentQueries() throws

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175519#comment-17175519 ] Dawid Weiss commented on LUCENE-9439: - Seems to pass all tests and checks. Works for

[jira] [Commented] (SOLR-14630) CloudSolrClient doesn't pick correct core when server contains more shards

2020-08-11 Thread Ivan Djurasevic (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175518#comment-17175518 ] Ivan Djurasevic commented on SOLR-14630: {quote}When you say "batch update", do y

[GitHub] [lucene-solr] gerlowskija merged pull request #1707: SOLR-14692: Allow 'method' specification on JSON Facet join domain transforms

2020-08-11 Thread GitBox
gerlowskija merged pull request #1707: URL: https://github.com/apache/lucene-solr/pull/1707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (SOLR-14692) JSON Facet "join" domain should take optional "method" property

2020-08-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175514#comment-17175514 ] ASF subversion and git services commented on SOLR-14692: Commit 5

[GitHub] [lucene-solr] gerlowskija commented on pull request #1707: SOLR-14692: Allow 'method' specification on JSON Facet join domain transforms

2020-08-11 Thread GitBox
gerlowskija commented on pull request #1707: URL: https://github.com/apache/lucene-solr/pull/1707#issuecomment-671912624 Thanks for the review Munendra; I made the changes you suggested. Merging now. This is an automated me

[jira] [Commented] (LUCENE-9439) Matches API should enumerate hit fields that have no positions (no iterator)

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175481#comment-17175481 ] Dawid Weiss commented on LUCENE-9439: - A cleaned up version in the PR. Running tests

[GitHub] [lucene-solr] atris edited a comment on pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-11 Thread GitBox
atris edited a comment on pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671879842 > The configuration can be as simple as > > `` > > This way you can just read all the attributes all at once from the `PluginInfo` . > CircuitBreaker sh

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-08-11 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175453#comment-17175453 ] Atri Sharma commented on SOLR-14588: As discussed offline, this can be done as a refa

[GitHub] [lucene-solr] atris commented on pull request #1737: SOLR-14615: Implement CPU Utilization Based Circuit Breaker

2020-08-11 Thread GitBox
atris commented on pull request #1737: URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671879842 > The configuration can be as simple as > > `` > > This way you can just read all the attributes all at once from the `PluginInfo` . > CircuitBreaker should be

[jira] [Resolved] (LUCENE-9454) Upgrade hamcrest to version 2.2

2020-08-11 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9454. - Resolution: Fixed > Upgrade hamcrest to version 2.2 > --- > >

[jira] [Commented] (LUCENE-9454) Upgrade hamcrest to version 2.2

2020-08-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175420#comment-17175420 ] ASF subversion and git services commented on LUCENE-9454: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #1738: LUCENE-9454: upgrade hamcrest to version 2.2.

2020-08-11 Thread GitBox
dweiss merged pull request #1738: URL: https://github.com/apache/lucene-solr/pull/1738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-08-11 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175402#comment-17175402 ] Noble Paul edited comment on SOLR-14588 at 8/11/20, 9:38 AM: -

[jira] [Comment Edited] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2020-08-11 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175402#comment-17175402 ] Noble Paul edited comment on SOLR-14588 at 8/11/20, 9:38 AM: -

  1   2   >