dweiss commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r469031590
##########
File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java
##########
@@ -440,7 +440,7 @@ public static final SegmentInfos readCommit(Directory
directory, ChecksumIndexIn
if (format >= VERSION_70) { // oldest supported version
CodecUtil.checkFooter(input, priorE);
} else {
- throw IOUtils.rethrowAlways(priorE);
Review comment:
And what's wrong about a throw from within finally? A finally block is
technically just a block of code, like any other. The compiler very likely
assumes you're suppressing an exception if you throw from within finally but
it's not the case here.
I don't know if moving that throw will change the logic. Maybe not. Maybe
yes. Given the two options, I wouldn't touch it. My concern was that you
slipped such things as part of an otherwise "trivial" set of patches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
