madrob commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468709509
##########
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##########
@@ -66,20 +65,19 @@ public void testConcurrentQueries() throws Exception {
solrDispatchFilter.replaceRateLimitManager(rateLimitManager);
- processTest(client);
+ processTest(client, 10000 /* number of documents */, 350 /* number of
queries */);
MockRequestRateLimiter mockQueryRateLimiter = (MockRequestRateLimiter)
rateLimitManager.getRequestRateLimiter(SolrRequest.SolrRequestType.QUERY);
- assertEquals(25, mockQueryRateLimiter.incomingRequestCount.get());
- assertTrue("Incoming accepted new request count did not match. Expected 5
incoming " + mockQueryRateLimiter.acceptedNewRequestCount.get(),
- mockQueryRateLimiter.acceptedNewRequestCount.get() < 25);
- assertTrue("Incoming rejected new request count did not match. Expected 20
incoming " + mockQueryRateLimiter.rejectedRequestCount.get(),
- mockQueryRateLimiter.rejectedRequestCount.get() > 0);
+ assertEquals(350, mockQueryRateLimiter.incomingRequestCount.get());
+
+ assertTrue((mockQueryRateLimiter.acceptedNewRequestCount.get() ==
mockQueryRateLimiter.incomingRequestCount.get()
Review comment:
Should we assert that accepted + rejected = total?
And that accepted > 0.
##########
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##########
@@ -48,7 +47,7 @@ public static void setupCluster() throws Exception {
configureCluster(1).addConfig(FIRST_COLLECTION,
configset("cloud-minimal")).configure();
}
- @Test
+ @Nightly
Review comment:
This isn't what I meant, sorry for being unclear. Keep this as `@Test`
but when selecting the number of documents and queries do something like
https://github.com/apache/lucene-solr/blob/master/lucene/core/src/test/org/apache/lucene/index/TestMultiDocValues.java#L52
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
