atris commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468681532
##########
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##########
@@ -66,15 +66,11 @@ public void testConcurrentQueries() throws Exception {
solrDispatchFilter.replaceRateLimitManager(rateLimitManager);
- processTest(client);
+ processTest(client, 10000 /* number of documents */, 350 /* number of
queries */);
MockRequestRateLimiter mockQueryRateLimiter = (MockRequestRateLimiter)
rateLimitManager.getRequestRateLimiter(SolrRequest.SolrRequestType.QUERY);
- assertEquals(25, mockQueryRateLimiter.incomingRequestCount.get());
- assertTrue("Incoming accepted new request count did not match. Expected 5
incoming " + mockQueryRateLimiter.acceptedNewRequestCount.get(),
Review comment:
It isnt really a relaxation -- the remaining assert should cover for all
cases that can happen for rate limiting. The catch is that rate limiting is not
a guaranteed phenomenon -- we create a high load and it should happen. I have
added an additional assert -- let me know if it looks fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
