madrob commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468724755
##########
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##########
@@ -66,20 +65,19 @@ public void testConcurrentQueries() throws Exception {
solrDispatchFilter.replaceRateLimitManager(rateLimitManager);
- processTest(client);
+ processTest(client, 10000 /* number of documents */, 350 /* number of
queries */);
MockRequestRateLimiter mockQueryRateLimiter = (MockRequestRateLimiter)
rateLimitManager.getRequestRateLimiter(SolrRequest.SolrRequestType.QUERY);
- assertEquals(25, mockQueryRateLimiter.incomingRequestCount.get());
- assertTrue("Incoming accepted new request count did not match. Expected 5
incoming " + mockQueryRateLimiter.acceptedNewRequestCount.get(),
- mockQueryRateLimiter.acceptedNewRequestCount.get() < 25);
- assertTrue("Incoming rejected new request count did not match. Expected 20
incoming " + mockQueryRateLimiter.rejectedRequestCount.get(),
- mockQueryRateLimiter.rejectedRequestCount.get() > 0);
+ assertEquals(350, mockQueryRateLimiter.incomingRequestCount.get());
+
+ assertTrue((mockQueryRateLimiter.acceptedNewRequestCount.get() ==
mockQueryRateLimiter.incomingRequestCount.get()
Review comment:
yea I was looking at the wrong side of the diff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
