atris commented on a change in pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468756781
##########
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##########
@@ -811,10 +818,18 @@ private void initLibs(SolrResourceLoader loader, boolean
isConfigsetTrusted) {
loader.reloadLuceneSPI();
}
- private void validateMemoryBreakerThreshold() {
+ private void validateCircuitBreakerThresholds() {
if (useCircuitBreakers) {
- if (memoryCircuitBreakerThresholdPct > 95 ||
memoryCircuitBreakerThresholdPct < 50) {
- throw new IllegalArgumentException("Valid value range of
memoryCircuitBreakerThresholdPct is 50 - 95");
+ if (isMemoryCircuitBreakerEnabled) {
+ if (memoryCircuitBreakerThresholdPct > 95 ||
memoryCircuitBreakerThresholdPct < 50) {
+ throw new IllegalArgumentException("Valid value range of
memoryCircuitBreakerThresholdPct is 50 - 95");
+ }
+ }
+
+ if (isCpuCircuitBreakerEnabled) {
+ if (cpuCircuitBreakerThresholdPct > 95 ||
cpuCircuitBreakerThresholdPct < 40) {
+ throw new IllegalArgumentException("Valid value range for
cpuCircuitBreakerThresholdPct is 40 - 95");
Review comment:
I see values between 0 - 100. Ran stress locally and validated values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
