mikemccand commented on a change in pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#discussion_r468812527
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##########
@@ -323,8 +323,10 @@ public FacetLabel getPath(int ordinal) throws IOException {
}
}
- Document doc = indexReader.document(ordinal);
- FacetLabel ret = new
FacetLabel(FacetsConfig.stringToPath(doc.get(Consts.FULL)));
+ boolean found = MultiDocValues.getBinaryValues(indexReader,
Consts.FULL).advanceExact(catIDInteger);
Review comment:
One more idea: instead of using `MultiDocValues` sugar, I think we
should use Lucene's `ReaderUtil` to quickly (binary search) determine which
leaf holds this `docId`, then pull `BinaryDocValues` from that `LeafReader`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
