dweiss commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r469027938
##########
File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java
##########
@@ -367,12 +367,12 @@ public void close() {
/**
* Original source of the tokens.
*/
- protected final Consumer<Reader> source;
Review comment:
Maybe. It doesn't matter though - this changes the API of a class that's
been there for ages. I bet there is a class out there somewhere (let's say A
extends Analyzer) and another one (B extends A) where A overrides the getter
but B reaches out for the original field. Do we want this to break just to hide
a field that can be useful for subclasses just to silence an automatic code
inspection? I don't think we should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
