[jira] [Updated] (SOLR-14392) CloudSolrClient executes select calls but not updates after adding authentication

2020-04-06 Thread Constantin Mitocaru (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Constantin Mitocaru updated SOLR-14392: --- Description: I'm trying to upgrade from 8.3.1 to 8.5.0 and I was forced to enable au

[jira] [Updated] (SOLR-14392) CloudSolrClient executes select calls but not updates after adding authentication

2020-04-06 Thread Constantin Mitocaru (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Constantin Mitocaru updated SOLR-14392: --- Summary: CloudSolrClient executes select calls but not updates after adding authentic

[jira] [Created] (SOLR-14392) Solr Cloud 8.5.0 executes select calls but not updates after adding authentication

2020-04-06 Thread Constantin Mitocaru (Jira)
Constantin Mitocaru created SOLR-14392: -- Summary: Solr Cloud 8.5.0 executes select calls but not updates after adding authentication Key: SOLR-14392 URL: https://issues.apache.org/jira/browse/SOLR-14392

[GitHub] [lucene-solr] dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
dnhatn commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404531138 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java #

[GitHub] [lucene-solr] dsmiley commented on issue #1412: Add MinimalSolrTest for scale testing

2020-04-06 Thread GitBox
dsmiley commented on issue #1412: Add MinimalSolrTest for scale testing URL: https://github.com/apache/lucene-solr/pull/1412#issuecomment-610152956 How exactly will we be capturing these times & plotting them? As a regression test, we need actual timeout thresholds, and perhaps assum

[GitHub] [lucene-solr] mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-06 Thread GitBox
mayya-sharipova commented on issue #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#issuecomment-610078508 @romseygeek Thanks for the feedback. I have addressed your comments 1 and 2 in 89d241e. Indeed, the APIs look sim

[jira] [Commented] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076726#comment-17076726 ] Adrian Nistor commented on LUCENE-9306: --- > The patch doesn't appear to include any

[jira] [Commented] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076723#comment-17076723 ] Lucene/Solr QA commented on LUCENE-9306: | (x) *{color:red}-1 overall{color}* |

[GitHub] [lucene-solr] saatchibhalla opened a new pull request #1414: SOLR-14385 added shard name thru MDC and collection name to split histogram logs

2020-04-06 Thread GitBox
saatchibhalla opened a new pull request #1414: SOLR-14385 added shard name thru MDC and collection name to split histogram logs URL: https://github.com/apache/lucene-solr/pull/1414 # Description Please provide a short description of the changes you're making with this pu

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1407: Use QueryUtils.combineQueryAndFilter more

2020-04-06 Thread GitBox
dsmiley commented on a change in pull request #1407: Use QueryUtils.combineQueryAndFilter more URL: https://github.com/apache/lucene-solr/pull/1407#discussion_r404385251 ## File path: solr/core/src/java/org/apache/solr/search/QueryUtils.java ## @@ -151,7 +151,7 @@ public s

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1407: Use QueryUtils.combineQueryAndFilter more

2020-04-06 Thread GitBox
dsmiley commented on a change in pull request #1407: Use QueryUtils.combineQueryAndFilter more URL: https://github.com/apache/lucene-solr/pull/1407#discussion_r404385251 ## File path: solr/core/src/java/org/apache/solr/search/QueryUtils.java ## @@ -151,7 +151,7 @@ public s

[jira] [Commented] (SOLR-14389) Support dynamic reconfiguration of Zookeeper ensemble

2020-04-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076623#comment-17076623 ] Jan Høydahl commented on SOLR-14389: I thought exactly the same. Not the hardest thin

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-610009448 @mikemccand @dnhatn I went through DWPTFlushControl one more time to add documentation to all the different lists we have in the

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Component/s: modules/replicator > The check against null and usage of the field updateThread i

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Lucene Fields: New,Patch Available (was: New) > The check against null and usage of the field

[jira] [Commented] (SOLR-14388) Remove references to rule-based replica placement in the ref guide

2020-04-06 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076598#comment-17076598 ] Cassandra Targett commented on SOLR-14388: -- Note there is already a page on how

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Description: h1. Github Pull Request I created a pull request on github for this issue at: [

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Status: Patch Available (was: Open) > The check against null and usage of the field updateThr

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Status: Open (was: Patch Available) > The check against null and usage of the field updateThr

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Attachment: LUCENE-9306.patch > The check against null and usage of the field updateThread is

[jira] [Updated] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Nistor updated LUCENE-9306: -- Status: Patch Available (was: Open) > The check against null and usage of the field updateThr

[jira] [Created] (LUCENE-9306) The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread Adrian Nistor (Jira)
Adrian Nistor created LUCENE-9306: - Summary: The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location. Key: LUCENE-9306 URL: https://issues.apache

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404323981 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@ -322,35

[GitHub] [lucene-solr] adriannistor opened a new pull request #1413: The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location.

2020-04-06 Thread GitBox
adriannistor opened a new pull request #1413: The check against null and usage of the field updateThread is typically protected by synchronization, but not in 1 location. URL: https://github.com/apache/lucene-solr/pull/1413 Checks against `null` and usages of the field `updateThread` are

[GitHub] [lucene-solr] madrob opened a new pull request #1412: Add MinimalSolrTest for scale testing

2020-04-06 Thread GitBox
madrob opened a new pull request #1412: Add MinimalSolrTest for scale testing URL: https://github.com/apache/lucene-solr/pull/1412 This test class does a few very basic things, but it does them at several scales. Improvements to this test will impact nearly everything else in the test

[jira] [Commented] (SOLR-14381) Handle integer overflow in grouping

2020-04-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076492#comment-17076492 ] Ishan Chattopadhyaya commented on SOLR-14381: - Tested this using a real clust

[jira] [Commented] (SOLR-14381) Handle integer overflow in grouping

2020-04-06 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076490#comment-17076490 ] Ishan Chattopadhyaya commented on SOLR-14381: - Added PR for branch_8x (master

[GitHub] [lucene-solr] chatman opened a new pull request #1411: SOLR-14381: Integer overflow in total count in grouping results

2020-04-06 Thread GitBox
chatman opened a new pull request #1411: SOLR-14381: Integer overflow in total count in grouping results URL: https://github.com/apache/lucene-solr/pull/1411 Integer overflow in total count in grouping results. Please note that this is a PR on branch_8x, since it is more complex than th

[GitHub] [lucene-solr] chatman opened a new pull request #1410: LUCENE-9302: Grouping to use long to avoid overflows

2020-04-06 Thread GitBox
chatman opened a new pull request #1410: LUCENE-9302: Grouping to use long to avoid overflows URL: https://github.com/apache/lucene-solr/pull/1410 Using long instead of int to avoid overflows of hits and counts when multiple shards are involved. ---

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1398: SOLR-13101: Every BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED irrespective of failures

2020-04-06 Thread GitBox
mbwaheed commented on a change in pull request #1398: SOLR-13101: Every BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED irrespective of failures URL: https://github.com/apache/lucene-solr/pull/1398#discussion_r404246925 ## File path: solr/core/src/java/org/apache/solr/

[jira] [Commented] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-06 Thread Yonik Seeley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076469#comment-17076469 ] Yonik Seeley commented on SOLR-14391: - bq. Why? Given that this dates back to Lucene

[jira] [Commented] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076444#comment-17076444 ] David Smiley commented on SOLR-14391: - SOLR-5416 introduced ScoreFilter. I'm really

[GitHub] [lucene-solr] dsmiley opened a new pull request #1409: SOLR-14391: getDocSet(Query[]) can use search(query, collector)

2020-04-06 Thread GitBox
dsmiley opened a new pull request #1409: SOLR-14391: getDocSet(Query[]) can use search(query,collector) URL: https://github.com/apache/lucene-solr/pull/1409 See https://issues.apache.org/jira/browse/SOLR-14391 Refactoring to simplify SolrIndexSearcher. ScoreFilter is obsolete now.

[jira] [Created] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

2020-04-06 Thread David Smiley (Jira)
David Smiley created SOLR-14391: --- Summary: Remove getDocSet's manual doc collection logic; remove ScoreFilter Key: SOLR-14391 URL: https://issues.apache.org/jira/browse/SOLR-14391 Project: Solr

[jira] [Comment Edited] (SOLR-14389) Support dynamic reconfiguration of Zookeeper ensemble

2020-04-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076425#comment-17076425 ] Houston Putman edited comment on SOLR-14389 at 4/6/20, 3:45 PM: ---

[jira] [Commented] (SOLR-14389) Support dynamic reconfiguration of Zookeeper ensemble

2020-04-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076425#comment-17076425 ] Houston Putman commented on SOLR-14389: --- It's amazing to me that something like the

[jira] [Commented] (SOLR-14371) Zk StatusHandler should know about dynamic zk config

2020-04-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076402#comment-17076402 ] Houston Putman commented on SOLR-14371: --- +1 I like the new patch, and I think it's

[jira] [Updated] (SOLR-14390) Unable to flush solr status when nested paths are present

2020-04-06 Thread Karl Stoney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Stoney updated SOLR-14390: --- Description: Hi, When attempting to flush all existing status as per the upgrade guide for 8.4.x ->

[jira] [Created] (SOLR-14390) Unable to flush solr status when nested paths are present

2020-04-06 Thread Karl Stoney (Jira)
Karl Stoney created SOLR-14390: -- Summary: Unable to flush solr status when nested paths are present Key: SOLR-14390 URL: https://issues.apache.org/jira/browse/SOLR-14390 Project: Solr Issue Type

[jira] [Updated] (LUCENE-8050) PerFieldDocValuesFormat's merge should not grab field DVF if DocValuesType.NONE

2020-04-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8050: - Fix Version/s: 8.6 Priority: Minor (was: Major) Thanks Juan! I'll merge tomorrow. >

[jira] [Commented] (SOLR-12276) Admin UI - Convert from "AngularJS" to "Angular"

2020-04-06 Thread Upayavira (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076333#comment-17076333 ] Upayavira commented on SOLR-12276: -- So as [~erickerickson]  said, the UI was originally

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-609780337 @mikemccand @dnhatn I pushed new commits and replied to you comments ---

[GitHub] [lucene-solr] s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on issue #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#issuecomment-609778263 > Have we changed the behavior of thread affinity (which DWPT an indexing thread will pull to index a new document), or of flush

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404068913 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@ -322,35

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404068194 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java #

[GitHub] [lucene-solr] dweiss commented on issue #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

2020-04-06 Thread GitBox
dweiss commented on issue #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects URL: https://github.com/apache/lucene-solr/pull/1388#issuecomment-609751515 Hi Tomoko. I made a few minor changes. It is a contract of task.getTemporaryDir that the dire

[jira] [Commented] (SOLR-12276) Admin UI - Convert from "AngularJS" to "Angular"

2020-04-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076271#comment-17076271 ] Erick Erickson commented on SOLR-12276: --- Marcus: I second what Jan said. And I sho

[jira] [Commented] (SOLR-6205) Make SolrCloud Data-center, rack or zone aware

2020-04-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076259#comment-17076259 ] Erick Erickson commented on SOLR-6205: -- [~noble.paul] [~shalin] Can we close this?

[jira] [Resolved] (SOLR-11476) Solr seems to ignore replica placement rules

2020-04-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-11476. --- Resolution: Won't Fix Rule-based replica placement is deprecated. Starting with Solr 7, polic

[jira] [Resolved] (SOLR-10733) Rule-based Replica Placement not working correct

2020-04-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-10733. --- Resolution: Won't Fix Rule-based replica placement is deprecated. Starting with Solr 7, polic

[jira] [Resolved] (SOLR-11634) Create collection doesn't respect `maxShardsPerNode`

2020-04-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-11634. --- Resolution: Won't Fix Rule-based replica placement is deprecated. Starting with Solr 7, polic

[jira] [Commented] (SOLR-14371) Zk StatusHandler should know about dynamic zk config

2020-04-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076245#comment-17076245 ] Jan Høydahl commented on SOLR-14371: [~houston] what do you think about the current p

[jira] [Updated] (SOLR-14371) Zk StatusHandler should know about dynamic zk config

2020-04-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14371: --- Description: With v3.5, Zookeeper supports [dynamic reconfig|https://zookeeper.apache.org/doc/r3.6.0

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404003919 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java ##

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404003278 ## File path: lucene/core/src/java/org/apache/lucene/index/FlushPolicy.java ## @@ -52,38 +50,

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r404001963 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -3774,6

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403998476 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403997925 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java #

[jira] [Commented] (LUCENE-8050) PerFieldDocValuesFormat's merge should not grab field DVF if DocValuesType.NONE

2020-04-06 Thread juan camilo rodriguez duran (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076214#comment-17076214 ] juan camilo rodriguez duran commented on LUCENE-8050: - [~dsmiley] I

[GitHub] [lucene-solr] juanka588 opened a new pull request #1408: LUCENE-8050 Ignore fields having no doc values when merging PerFieldDVFormat

2020-04-06 Thread GitBox
juanka588 opened a new pull request #1408: LUCENE-8050 Ignore fields having no doc values when merging PerFieldDVFormat URL: https://github.com/apache/lucene-solr/pull/1408 # Description PerFieldDocValuesFormat delegates the merge to the actual field DVF's merge. Great, but unfortun

[jira] [Commented] (SOLR-12276) Admin UI - Convert from "AngularJS" to "Angular"

2020-04-06 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076204#comment-17076204 ] Jan Høydahl commented on SOLR-12276: There are many opinions around admin UI. So I th

[jira] [Commented] (SOLR-12276) Admin UI - Convert from "AngularJS" to "Angular"

2020-04-06 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076173#comment-17076173 ] Marcus Eagan commented on SOLR-12276: - [~erickerickson][~jdyer] It looks like this ti

[jira] [Commented] (SOLR-12276) Admin UI - Convert from "AngularJS" to "Angular"

2020-04-06 Thread Marcus Eagan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076172#comment-17076172 ] Marcus Eagan commented on SOLR-12276: - [~erickerickson][~jdyer] It looks like this ti

[GitHub] [lucene-solr] s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly

2020-04-06 Thread GitBox
s1monw commented on a change in pull request #1397: LUCENE-9304: Refactor DWPTPool to pool DWPT directly URL: https://github.com/apache/lucene-solr/pull/1397#discussion_r403946415 ## File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java ## @@ -273,33