juanka588 opened a new pull request #1408: LUCENE-8050 Ignore fields having no doc values when merging PerFieldDVFormat URL: https://github.com/apache/lucene-solr/pull/1408 # Description PerFieldDocValuesFormat delegates the merge to the actual field DVF's merge. Great, but unfortunately it will call getDocValuesFormatForField on all fields (in FieldInfos) even those that have no DocValues (DocValuesType.NONE) # Solution Skip FieldInfo when getDocValuesType() == DocValuesType.NONE # Tests Test added using doc values in one segment and indexed fields in the other, we asses that the fields not having doc values are skipped while merging. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [] I have run `ant precommit` and the appropriate test suite. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
