[
https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076444#comment-17076444
]
David Smiley commented on SOLR-14391:
-------------------------------------
SOLR-5416 introduced ScoreFilter. I'm really displeased by that mechanism on
multiple levels: lack of documentation on this marker interface, and adding
needless complexity into SolrIndexSearcher, and dubious choice of not caching
the first query in the list (vs adding MatchAllDocsQuery) thus violating what
getDocSet says it will do (cache). [~jbernste] please take a look at my PR
(pending)
Since ScoreFilter is not documented and only used by one query, I think it can
just disappear in 8x when this is merged.
[~yonik] I believe you wrote the manual doc loop, filter, collection logic
there and thus chose not to use Lucene. Why? BulkScorer was introduced in 4.8
but there was some older mechanism pre-dating that.
> Remove getDocSet's manual doc collection logic; remove ScoreFilter
> ------------------------------------------------------------------
>
> Key: SOLR-14391
> URL: https://issues.apache.org/jira/browse/SOLR-14391
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
>
> {{SolrIndexSearcher.getDocSet(List<Query>)}} calls getProcessedFilter and
> then basically loops over doc IDs, passing them through the filter, and
> passes them to the Collector. This logic is redundant with what Lucene
> searcher.search(query,collector) will ultimately do in BulkScorer, and so I
> propose we remove all that code and delegate to Lucene.
> Also, the top of this method looks to see if any query implements the
> "ScoreFilter" marker interface (only implemented by CollapsingPostFilter) and
> if so delegates to {{getDocSetScore}} method instead. That method has an
> implementation close to what I propose getDocSet be changed to; so it can be
> removed along with this ScoreFilter interface
> searcher.search(query,collector).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
