mbwaheed commented on a change in pull request #1398: SOLR-13101: Every
BLOB_PULL_STARTED should have a matching BLOB_PULL_FINISHED irrespective of
failures
URL: https://github.com/apache/lucene-solr/pull/1398#discussion_r404246925
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/process/CorePullTask.java
##########
@@ -354,10 +353,10 @@ void pullCoreFromBlob(boolean isLeaderPulling) throws
InterruptedException {
}
}
}
+ concurrencyController.recordState(pullCoreInfo.getCollectionName(),
pullCoreInfo.getShardName(), pullCoreInfo.getCoreName(),
SharedCoreStage.BLOB_PULL_FINISHED);
Review comment:
This is meant to be matching BLOB_PULL_STARTED (line#248). At this place,
depending on failures, it can be logged without BLOB_PULL_STARTED. You would
need to put a new try after line#248 and a finally before line# 320. And then
put this line inside that new finally.
Side note: This method needs some refactoring to simplify its flow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
