[
https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076469#comment-17076469
]
Yonik Seeley commented on SOLR-14391:
-------------------------------------
bq. Why?
Given that this dates back to Lucene 3.2 or so, it was probably the most
performant way, regardless if there was another way or not.
> Remove getDocSet's manual doc collection logic; remove ScoreFilter
> ------------------------------------------------------------------
>
> Key: SOLR-14391
> URL: https://issues.apache.org/jira/browse/SOLR-14391
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{SolrIndexSearcher.getDocSet(List<Query>)}} calls getProcessedFilter and
> then basically loops over doc IDs, passing them through the filter, and
> passes them to the Collector. This logic is redundant with what Lucene
> searcher.search(query,collector) will ultimately do in BulkScorer, and so I
> propose we remove all that code and delegate to Lucene.
> Also, the top of this method looks to see if any query implements the
> "ScoreFilter" marker interface (only implemented by CollapsingPostFilter) and
> if so delegates to {{getDocSetScore}} method instead. That method has an
> implementation close to what I propose getDocSet be changed to; so it can be
> removed along with this ScoreFilter interface
> searcher.search(query,collector).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
